1281 Commits

Author SHA1 Message Date
Christoph M. Becker
710992c22f Add more spam words for user notes
Recently, we get an awful lot of spam; let's constrain it.
2022-08-05 18:07:38 +02:00
Nikita Popov
369ff2016a Try adding Reply-To header to commit mails
Not sure whether this will get stripped by the mailing list, but
let's try it. I don't want to specify the author/committer email
in From, as it'll likely run afoul of DMARC.
2021-04-02 22:43:57 +02:00
Nikita Popov
89fd8c2964 Try to fix mail charset issue
Set utf-8 as the charset when using PHPMailer. The manual encoding
code was a leftover from direct calls to mail() and only handles
the charset in the subject but not other headers.
2021-04-02 22:08:41 +02:00
Nikita Popov
d0cac5411f Make "Fixed bug" check case-insensitive 2021-04-01 22:26:49 +02:00
Nikita Popov
9cfe978d68 Remove magic_quotes filter handling
The magic quotes filter is now disabled.
2021-04-01 20:53:45 +02:00
Nikita Popov
81b302aac8 Finish migration to safe queries 2021-04-01 19:05:40 +02:00
Nikita Popov
cb44bbe51e Fix a typo 2021-04-01 18:44:26 +02:00
Nikita Popov
690a735209 Adjust note.sql schema to work on current MySQL 2021-04-01 18:43:09 +02:00
Nikita Popov
e69d94b23c Fix event searchby logic
The !$searchby checks no longer did something meaningful after
switching to the Query object.
2021-04-01 18:27:29 +02:00
Nikita Popov
2e2d507fed Let me view phpinfo 2021-04-01 17:55:37 +02:00
Nikita Popov
1a08ce75cd Migrate more code to safe query abstraction
Getting closer to done...
2021-04-01 17:52:12 +02:00
Nikita Popov
6135e250d1 Move more queries to safe abstraction
Add a Query class to assemble queries by parts, and ?int placeholder
which is needed for LIMIT clauses.
2021-04-01 16:28:24 +02:00
Nikita Popov
3f5dc40db4 Use db_query_safe() in more places
Replace most of the raw mysql_query() calls.
2021-04-01 15:09:01 +02:00
Nikita Popov
0a86f8431a Remove fetch/countries.php
This was used by scripts/update-backend at one point, now the
list is hardcoded.
2021-04-01 14:40:24 +02:00
Nikita Popov
64defdfc2f Remove unused mirrors.sql
We no longer have mirrors.
2021-04-01 14:21:03 +02:00
Nikita Popov
105450fc56 Remove alerts functionality
This was never used, and is in a broken state right now (references
an incorrect database schema).

It seems rather unlikely that this functionality is going to be
finished at this point, so instead drop it entirely.
2021-04-01 13:13:08 +02:00
Nikita Popov
2163871e4f Use db_query_safe() in forgot.php 2021-04-01 12:46:16 +02:00
Nikita Popov
ed931f77c1 Add safe(r) query abstraction
Add db_query_safe that accepts parameters separately. Use it in
some places.
2021-04-01 12:31:37 +02:00
Nikita Popov
6cc0deb4c4 Use db_connect() in some places 2021-04-01 11:32:53 +02:00
Nikita Popov
5f64a408e9 Add basic instructions for local setup
Not to make everything work, but at least something...
2021-04-01 11:15:14 +02:00
Nikita Popov
5b8719f285 Don't handle full_special_chars default.filter
default.filter on this server is set to magic_quotes, so remove
the handling for the full_special_chars case.
2021-04-01 10:24:19 +02:00
Nikita Popov
6488d65ae6 Handle optional github user name
Author/committer may not necessarily have a github account.
2021-04-01 00:26:34 +02:00
Nikita Popov
d0822675ee Replace uses of escape() with appropriate functions
For queries, use real_clean(), for html use hsrc().
2021-03-31 22:40:35 +02:00
Nikita Popov
c8506579ad Remove get_magic_quotes_gpc() checks
master.php.net runs PHP 5.4, where magic quotes no longer exist.
Add a sanity check that they're really disable, and drop code
handling them. There was at least one use of escape() that wouldn't
do the right thing if this code was run with magic quotes.
2021-03-31 22:29:09 +02:00
Nikita Popov
68c0837938 Use strict comparison for password
Rather unlikely, but could give false positives for 0e comparisons.
2021-03-31 21:36:49 +02:00
Nikita Popov
e22ac4f3a5 Also include pusher name 2021-03-31 21:03:17 +02:00
Nikita Popov
c0b0e18a4c Disable diffs, enable general commit mails
Fetching diffs fails on master.php.net -- I suspect that this is
because it's too old to support TLS 1.2. Inline diff display
should be enabled once the box has been migrated.
2021-03-31 18:29:07 +02:00
Nikita Popov
2cab6e865a Send commit mail 2021-03-31 17:13:25 +02:00
Nikita Popov
cfbbcff722 Send mail for ref create/delete/force 2021-03-31 15:33:09 +02:00
Sergey Panteleev
f14e88a6a9 Fix email message (#5) 2021-03-31 12:10:09 +03:00
Nikita Popov
340756d5dd Remove bogus headers argument 2021-03-30 23:59:03 +02:00
Nikita Popov
e887adfd44 Switch webhook to PHPMailer 2021-03-30 22:04:03 +02:00
Nikita Popov
e9f2676cb8 Revert "Debug webhook"
This reverts commit 9602517f18.
2021-03-30 21:58:07 +02:00
Nikita Popov
9602517f18 Debug webhook
Request goes through now, but is rejected by bugs.php.net.
2021-03-30 20:21:01 +02:00
Nikita Popov
1bbe009dfe Use file_get_contents instead of curl
Possibly not present on master?
2021-03-30 19:57:23 +02:00
Rasmus Lerdorf
f417e150be Switch forgot.php to PHPMailer 2021-03-30 10:00:13 -07:00
Nikita Popov
8c7a80d162 Add webhook to auto-close bugs
This was previously handled as a post-receive hook. Now do this
in a push webhook instead.
2021-03-30 17:50:29 +02:00
Sergey Panteleev
be58f2bc17 Update web-shared submodule upstream (#3) 2021-03-29 18:05:41 +03:00
Rasmus Lerdorf
600780d700 More PHP 8/Phan fixes 2021-01-30 13:24:58 -08:00
Rasmus Lerdorf
48cb59d326 A bit of PHP 7.4/8.0 cleanup 2021-01-30 13:18:46 -08:00
Rasmus Lerdorf
c84cdc756a Add phan config 2021-01-30 12:45:55 -08:00
Sobak
37e617a5cc Drop around decade old redirects with no references these days 2020-06-30 07:23:38 +02:00
Peter Cowburn
f17c55f1cb use square brackets for string offset access 2020-06-29 15:10:19 +01:00
Peter Cowburn
fc7ab27cda skip Diffie-Hellman ciphers for fetching user notes from master (bug #79663)
Without this, fetching user notes fails on the rsync box with the
OpenSSL error (which is suppressed via the @ operator):

    error:141A318A:SSL routines:tls_process_ske_dhe:dh key too small

TODO: likely other scripts need similar treatment until Apache is
upgraded on master.
2020-06-07 11:33:13 +01:00
Martin Jansen
f0ad7ed751 Fix access to $argv[2] 2020-06-01 10:32:33 +02:00
Sobak
e471466e32 Final attempt to fix pagination? 2020-04-19 12:59:43 +02:00
Sobak
b8cf248dc8 Push temporary hidden debug message to help resolve pagination issue 2020-04-19 11:37:27 +02:00
Sobak
f2ba4f0a19 Notes: fixing pagination requires one more change 2020-04-19 09:34:50 +02:00
Sobak
5cd67eadf9 Notes: fix pagination
I feel like this empty() check is also incorrect in other places but I
don't know how to reproduce the potential issue so maybe better it's
to not touch it.
2020-04-19 07:43:07 +02:00
Sobak
6e4fd55e99 Remove overlooked assets for discontinued status.php.net 2020-04-19 07:35:51 +02:00