php/archived-pie
1
0
Fork 0
mirror of https://github.com/php/pie.git synced 2026-03-23 23:12:17 +01:00
Code Issues Packages Projects Releases Wiki Activity

436: fix up test expectations for pre-packaged binary DownloadUrlMethod

Browse Source
This commit is contained in:
James Titcumb
2026-01-08 15:38:42 +00:00
parent fee222d624
commit fbf0558c9d
2 changed files with 21 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/Platform/TargetPlatform.php
View File

@@ -21,7 +21,7 @@ use function trim;
*/
class TargetPlatform
{
private static LibcFlavour|null $libcFlavour;
private static LibcFlavour $libcFlavour;
public function __construct(
public readonly OperatingSystem $operatingSystem,

25
test/unit/Downloading/DownloadUrlMethodTest.php
View File

@@ -10,6 +10,7 @@ use Php\Pie\Downloading\DownloadUrlMethod;
use Php\Pie\ExtensionName;
use Php\Pie\ExtensionType;
use Php\Pie\Platform\Architecture;
use Php\Pie\Platform\DebugBuild;
use Php\Pie\Platform\OperatingSystem;
use Php\Pie\Platform\OperatingSystemFamily;
use Php\Pie\Platform\TargetPhp\PhpBinaryPath;
@@ -114,16 +115,19 @@ final class DownloadUrlMethodTest extends TestCase
$package = Package::fromComposerCompletePackage($composerPackage);
$phpBinaryPath = $this->createMock(PhpBinaryPath::class);
$phpBinaryPath->expects(self::any())
$phpBinaryPath
->method('majorMinorVersion')
->willReturn('8.3');
$phpBinaryPath
->method('debugMode')
->willReturn(DebugBuild::Debug);
$targetPlatform = new TargetPlatform(
OperatingSystem::NonWindows,
OperatingSystemFamily::Linux,
$phpBinaryPath,
Architecture::x86_64,
ThreadSafetyMode::NonThreadSafe,
ThreadSafetyMode::ThreadSafe,
1,
null,
);
@@ -136,7 +140,10 @@ final class DownloadUrlMethodTest extends TestCase
self::assertSame(DownloadUrlMethod::PrePackagedBinary, $downloadUrlMethod);
self::assertSame(
['php_bar-1.2.3_php8.3-x86_64-glibc-debug-nts.tgz'],
[
'php_bar-1.2.3_php8.3-x86_64-glibc-debug-zts.zip',
'php_bar-1.2.3_php8.3-x86_64-glibc-debug-zts.tgz',
],
$downloadUrlMethod->possibleAssetNames($package, $targetPlatform),
);
}
@@ -183,9 +190,12 @@ final class DownloadUrlMethodTest extends TestCase
$package = Package::fromComposerCompletePackage($composerPackage);
$phpBinaryPath = $this->createMock(PhpBinaryPath::class);
$phpBinaryPath->expects(self::any())
$phpBinaryPath
->method('majorMinorVersion')
->willReturn('8.3');
$phpBinaryPath
->method('debugMode')
->willReturn(DebugBuild::Debug);
$targetPlatform = new TargetPlatform(
OperatingSystem::NonWindows,
@@ -204,7 +214,12 @@ final class DownloadUrlMethodTest extends TestCase
$firstMethod = $downloadUrlMethods[0];
self::assertSame(DownloadUrlMethod::PrePackagedBinary, $firstMethod);
self::assertSame(
['php_bar-1.2.3_php8.3-x86_64-glibc-debug-nts.tgz'],
[
'php_bar-1.2.3_php8.3-x86_64-glibc-debug.zip',
'php_bar-1.2.3_php8.3-x86_64-glibc-debug.tgz',
'php_bar-1.2.3_php8.3-x86_64-glibc-debug-nts.zip',
'php_bar-1.2.3_php8.3-x86_64-glibc-debug-nts.tgz',
],
$firstMethod->possibleAssetNames($package, $targetPlatform),
);