Gina Peter Banyard e1b59e9edd ext/soap: Use more accurate return types in implementations of SoapClient::__doRequest() ...

The do_request() function that calls this methods, assumes that a string is being returned from the method
otherwise it bails out.

However, the default implementation of SoapClient::__doRequest() indicates that it can return null when it
fails to set-up and execute the HTTP SOAP request, but this always results in a SoapFault exception being
thrown, and thus cannot happen in practice.

We need to investigate further if the return type should be changed from ?string to string or not.

2024-06-19 02:23:08 +01:00

1.5 KiB

Raw Blame History

View Raw