Dmitrii Derepko
fdebad0b25
zend_ast: Add parentheses around IIFE in zend_ast_export() ( #18688 )
2025-05-29 15:47:47 +02:00
Niels Dossche
399cb4ca85
Fix misplaced endif in apprentice_sort() ( #18686 )
2025-05-29 12:04:07 +02:00
Niels Dossche
8b4edf0229
Remove unused function in soap
2025-05-29 10:02:43 +02:00
Niels Dossche
21691cb19b
Remove uncommented init/cleanup code
...
This is irrelevant and is done by ext/libxml.
2025-05-29 10:02:43 +02:00
Niels Dossche
564df33ac1
Add FIXME
2025-05-29 10:02:43 +02:00
Niels Dossche
6723e88798
Add const qualifiers for php_xml
2025-05-29 10:02:43 +02:00
Niels Dossche
ba80d0be99
Fix indentation
2025-05-29 10:02:43 +02:00
Niels Dossche
9e01337a21
Remove unused soap macros
2025-05-29 10:02:43 +02:00
Niels Dossche
a63d0a49b0
Merge branch 'PHP-8.4'
...
* PHP-8.4:
Update Lexbor patches for non-string attribute
2025-05-28 23:35:23 +02:00
Niels Dossche
9e9db0b22f
Update Lexbor patches for non-string attribute
...
This should fix the final sub-issue of GH-17687.
Closes GH-18691.
2025-05-28 23:34:08 +02:00
Ayesh Karunaratne
8e46d9a03a
ext/curl: format Caddyfile
2025-05-29 01:49:09 +05:30
Gina Peter Banyard
279983dc8d
ext/sockets: Use zval_is_true() instead of converting to boolean ( #18681 )
2025-05-28 20:06:47 +01:00
Niels Dossche
b05d50eac2
Avoid creating a zend_string twice in soap do_request
2025-05-28 21:04:06 +02:00
Niels Dossche
99bc0a56a6
Use function table directly in soap do_request
...
The function will exist, avoid creating a temporary string and
lowercasing it.
2025-05-28 21:04:06 +02:00
Niels Dossche
b156d37d7f
Use zend_array_is_list() in soap instead of own is_map() ( #18684 )
...
is_map() is just the inverse of zend_array_is_list().
2025-05-28 20:12:54 +02:00
Niels Dossche
3d51ba3479
Merge branch 'PHP-8.4'
...
* PHP-8.4:
Fix ZEND_NONSTRING attribute for data_file.c
2025-05-28 19:50:06 +02:00
Niels Dossche
b8e734a24e
Fix ZEND_NONSTRING attribute for data_file.c
...
This broke in CI but not on my local machine because of the different
compiler version. This is because there was an issue in GCC [1] that
caused the attribute to not properly work on multidimensional arrays.
This has since been fixed in GCC 15.
Therefore, we guard the attribute with a version check.
[1] https://gcc.gnu.org/cgit/gcc/commit/?id=afb46540d3921e96c4cd7ba8fa2c8b0901759455
2025-05-28 19:48:59 +02:00
Dmitrii Derepko
a0f3879a1f
chore: remove todo ( #18689 )
...
[ci skip]
2025-05-28 19:48:25 +02:00
Niels Dossche
4b2a580015
Merge branch 'PHP-8.4'
...
* PHP-8.4:
Fix GH-18642: Signed integer overflow in ext/phar fseek
2025-05-28 18:54:20 +02:00
Niels Dossche
d6ed107510
Merge branch 'PHP-8.3' into PHP-8.4
...
* PHP-8.3:
Fix GH-18642: Signed integer overflow in ext/phar fseek
2025-05-28 18:54:15 +02:00
Niels Dossche
61884c3b52
Fix GH-18642: Signed integer overflow in ext/phar fseek
...
The overflow checking code already existed, but didn't work because the
math was done on signed numbers instead of unsigned numbers.
In the process I also discovered a pre-existing issue that needs to be
fixed (and seems that other stream wrappers can have this issue too).
Closes GH-18644.
2025-05-28 18:53:55 +02:00
David CARLIER
c789e9c9f1
ext/sockets: socket_create_pair() simplify workflow. ( #18679 )
...
create the pair objects only on success.
2025-05-28 12:41:48 +01:00
Peter Kokot
25e8aa5cd2
Autotools: Fix ext/ldap shared build ( #18673 )
...
This fixes checks when building shared ldap library, or when ldap
installation directory is passed as argument:
./configure --with-ldap=shared
./configure --with-ldap=/path/to/ldap
./configure --with-ldap=shared,/path/to/ldap
2025-05-28 12:08:46 +01:00
Niels Dossche
c4fba3708c
Drop COMPILE_DL_LEXBOR ( #18677 )
...
This is always statically compiled into PHP, so remove this dead code.
2025-05-27 22:00:26 +02:00
Niels Dossche
cbe0cf6315
Merge branch 'PHP-8.4'
...
* PHP-8.4:
Temporarily drop attribute for fileinfo
2025-05-27 21:08:11 +02:00
Niels Dossche
877663178c
Temporarily drop attribute for fileinfo
...
The error in CI doesn't reproduce on my system with GCC 15.1.1...
2025-05-27 21:07:15 +02:00
Niels Dossche
c2749e0a80
Merge branch 'PHP-8.4'
...
* PHP-8.4:
Fix compile error for attribute
2025-05-27 21:01:39 +02:00
Niels Dossche
e4d2cd47c2
Fix compile error for attribute
2025-05-27 21:00:41 +02:00
Niels Dossche
12deb22f7f
Merge branch 'PHP-8.4'
...
* PHP-8.4:
Backport fix for GH-17687
2025-05-27 20:42:20 +02:00
Niels Dossche
d5515577d5
Merge branch 'PHP-8.3' into PHP-8.4
...
* PHP-8.3:
Backport fix for GH-17687
2025-05-27 20:42:12 +02:00
Niels Dossche
fab0a6d75c
Backport fix for GH-17687
...
Introducing a new attribute macro in lower branches is an ABI break and
not allowed. However, we still need to fix the warnings such that
-Werror builds don't break. So we copy the macro from the master branch
to the C files in the appropriate places.
2025-05-27 20:40:35 +02:00
Niels Dossche
6d4824e02e
Add UPGRADING.INTERNALS entry for ZEND_NONSTRING
...
[ci skip]
2025-05-27 20:29:50 +02:00
Niels Dossche
ea69276fd5
Fix GH-17687: initializer-string for array of ... warnings
...
Starting with gcc 15 the warning `-Wunterminated-string-initialization`
is enabled by default. We make now use of the `nonstring` attribute to
silence the warning for the cases where this is intended.
Closes GH-18603.
2025-05-27 20:28:29 +02:00
Máté Kocsis
400b7b8c74
Add Lexbor files for URL handling ( #18656 )
...
Relates to #14461 and https://wiki.php.net/rfc/url_parsing_api
2025-05-27 13:06:02 +02:00
Máté Kocsis
d585a5609d
Add ext/uri skeleton along with uriparser ( #18658 )
...
Relates to https://github.com/php/php-src/pull/14461/ and https://wiki.php.net/rfc/url_parsing_api
2025-05-27 08:16:24 +02:00
Saki Takamachi
c0865ac013
[skip ci] UPGRADING for #18413 and #18626
2025-05-27 13:47:39 +09:00
DanielEScherzer
de785f9127
Fix bad upmerge from GH-18464 ( #18666 )
...
This led to recursion being added to but not removed from internal constants.
2025-05-26 12:40:11 -07:00
Niels Dossche
0a2f367e19
Fix date test
2025-05-26 20:43:44 +02:00
David Carlier
5a7920ba60
ext/sockets: socket_shutdown() having proper constants for mode.
...
close GH-18648
2025-05-26 18:48:21 +01:00
Niels Dossche
cec079ee72
Merge branch 'PHP-8.4'
...
* PHP-8.4:
Fix memory leak in tidy output handler on error
Fix leaks with multiple calls to DatePeriod iterator current()
2025-05-26 19:42:39 +02:00
Niels Dossche
06f592820d
Merge branch 'PHP-8.3' into PHP-8.4
...
* PHP-8.3:
Fix memory leak in tidy output handler on error
Fix leaks with multiple calls to DatePeriod iterator current()
2025-05-26 19:42:20 +02:00
Niels Dossche
b39e17b06c
Fix memory leak in tidy output handler on error
...
Closes GH-18649.
2025-05-26 19:41:11 +02:00
Niels Dossche
ff2c7dc0f8
Fix leaks with multiple calls to DatePeriod iterator current()
...
Destroy the old value first. We can't skip recreating the value because
the object may have been changed in between calls.
Closes GH-18624.
2025-05-26 19:40:41 +02:00
Jessica Smith
042a975238
ext/session: Fix GH-18634 ( #18653 )
...
Show warning when saving session if a pipe character is used in one of the $_SESSION keys
Fixes #18634
2025-05-26 11:17:25 +01:00
Saki Takamachi
462fd4dffe
Small change SIMD codes ( #18626 )
...
* use zend_simd.h in zend_accelerator_util_funcs.c
* use zend_simd.h in mbstring
* Remove unnecessary SSE3 includes
2025-05-26 16:32:27 +09:00
Daniel Scherzer
04522cd1c4
Merge branch 'PHP-8.4'
...
* PHP-8.4:
Reapply GH-17712 with a fix for internal class constants (#18464 )
2025-05-25 16:51:18 -07:00
DanielEScherzer
cd751f98cb
Reapply GH-17712 with a fix for internal class constants ( #18464 )
...
Add recursion protection when emitting deprecation warnings for class
constants, since the deprecation message can come from an attribute that is
using the same constant for the message, or otherwise result in recursion.
But, internal constants are persisted, and thus cannot have recursion
protection. Otherwise, if a user error handler triggers bailout before the
recursion flag is removed then a subsequent request (e.g. with `--repeat 2`)
would start with that flag already applied. Internal constants can presumably
be trusted not to use deprecation messages that come from recursive attributes.
Fixes GH-18463
Fixes GH-17711
2025-05-25 16:43:36 -07:00
David CARLIER
7e956f879e
ext/soap: SoapServer::handle() reduce retval scope. ( #18657 )
...
might have been a relic of past modifications,
but pushing it down to the actual first case of error path.
2025-05-25 22:15:31 +01:00
Niels Dossche
c7db07eae8
Remove duplicated reflection test
...
[ci skip]
This is already tested in 016.phpt.
2025-05-25 14:24:53 +02:00
Niels Dossche
085abe932a
Pass hash table directly in tokenizer ( #18650 )
...
This avoids dereferences by Z_ARRVAL_P().
2025-05-25 14:23:50 +02:00