Christoph M. Becker
e2c17cef4b
Fix test for x86 Windows
...
`st_dev` deliberately overflows on such systems, cf.
<http://svn.php.net/viewvc?view=revision&revision=350100 >.
2020-07-13 10:52:26 +02:00
twosee
7a39e174aa
Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
Fixed BC break of php_debug_zval_dump
2020-07-11 18:31:30 +08:00
twosee
f0b2c2cb98
Fixed BC break of php_debug_zval_dump
...
It introduced by fixing bug #79830
2020-07-11 18:30:28 +08:00
twosee
6ef08b1903
Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
Fixed bug #79830 introduced by fixing bug #79821
2020-07-11 14:38:27 +08:00
twosee
56dec3cc73
Fixed bug #79830 introduced by fixing bug #79821
...
This also fixes memory error in debug_zval_dump and var_export.
2020-07-11 14:37:25 +08:00
twosee
8db2ae8ffb
Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
Fixed bug #79821
2020-07-11 06:15:28 +08:00
twosee
150504e6b1
Fixed bug #79821
...
HashTable was reallocated (zend_hash_packed_grow) during php_var_dump, so we should call GC_ADDREF to make SEPARATE_ARRAY work.
Closes GH-5837.
2020-07-11 06:14:22 +08:00
Nikita Popov
3f8d71d37f
Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
Fixed bug #79817
2020-07-10 14:07:17 +02:00
Nikita Popov
a72c53a070
Fixed bug #79817
...
Use *_IND macros in a few places in string.c.
2020-07-10 14:06:41 +02:00
Christoph M. Becker
99aa5484e2
Enable further ext/standard/tests/file tests on Windows
2020-07-10 13:36:41 +02:00
Christoph M. Becker
7edc5e5e39
Fix skip reasons
...
These tests fail on Windows for different reasons, but not because
symlinks, links, or lstat() would not be supported on Windows
generally.
2020-07-10 11:26:48 +02:00
Christoph M. Becker
68293b19d4
Enable symlink_link_linkinfo_is_link_* tests on Windows
...
We mark symlink_link_linkinfo_is_link_error2.phpt as XFAIL on Windows
ZTS. Several Windows API file system functions ignore trailing spaces
in absolute filenames after the final directory separator, which causes
`link(' ', $link)` to actually call `CreateHardLink()` which then
fails, because linking folders is not supported. However, with NTS
builds (as well as on other systems), the $target is found to not
exist, so the function fails without actually attempting to create the
link. This needs further investigation.
2020-07-10 10:08:12 +02:00
Paweł Tomulik
b291c92693
enable ext/ldap/tests on azure
2020-07-10 09:56:02 +02:00
Paweł Tomulik
c6ab3084df
fix some ext/ldap/tests
2020-07-10 09:56:02 +02:00
Nikita Popov
22352868ec
Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
Fix some memory bugs in ldap.c
2020-07-10 09:49:50 +02:00
Paweł Tomulik
23ef0a1285
Fix some memory bugs in ldap.c
2020-07-09 18:35:00 +02:00
Christoph M. Becker
db484b612d
Prevent parallel test conflicts
...
Both tests used the same folder, which could clash in case the tests
are run simultaneously.
2020-07-09 12:35:31 +02:00
Nikita Popov
8318379dd3
Switch back to FREE_UNFETCHED_OP_DATA
...
Some of the code paths leading to this do not fetch op data.
Hopefully this fixes the release build failure.
2020-07-09 11:54:08 +02:00
Nikita Popov
5795dfda93
Fix bug #79599 in a different way
...
Move the emission of the undefined variable notice before the
array separation.
2020-07-09 11:12:44 +02:00
Nikita Popov
a3cb612243
Revert "Fixed bug #97599 (coredump in set_error_handler)"
...
This reverts commit ccd41e0833 .
This causes a large performance regression when notices are thrown
and large arrays are in scope, see bug #79794 .
2020-07-09 11:12:44 +02:00
Derick Rethans
972383fda4
Revert "Partial fixed bug #79649 (Altering disable_functions from module init corrupts memory)"
...
This reverts commit a297c09da5 .
2020-07-09 09:50:25 +01:00
Nikita Popov
77a8a709da
Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
Fix bug #79787
2020-07-08 11:22:18 +02:00
XXiang
3d5de7d746
Fix bug #79787
...
Closes GH-5807.
2020-07-08 11:20:58 +02:00
Christoph M. Becker
776e872ab8
[ci skip] Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
Report len as -1 instead of INT_MAX
2020-07-08 10:40:13 +02:00
Nikita Popov
e6160e99d8
Report len as -1 instead of INT_MAX
...
Per docs it should be -1. And would be on 32-bit systems, but
not on 64-bit systems.
(cherry picked from commit 39111585a2 )
2020-07-08 10:38:11 +02:00
Sara Golemon
fef26361d0
Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
Prep for 7.2.33
Prep NEWS for 7.2.32 release
2020-07-07 19:34:08 +00:00
Sara Golemon
e54f18ae0f
Merge branch 'PHP-7.2' into PHP-7.3
...
* PHP-7.2:
Prep for 7.2.33
Prep NEWS for 7.2.32 release
2020-07-07 19:33:48 +00:00
Sara Golemon
c68d48de9e
Prep for 7.2.33
2020-07-07 19:32:15 +00:00
Sara Golemon
9588c8474e
Prep NEWS for 7.2.32 release
2020-07-07 19:31:05 +00:00
Nikita Popov
77acc8a069
Fixed bug #79793
...
Make sure the string key is not released while throwing the
undefined index warning.
2020-07-07 16:29:48 +02:00
Nikita Popov
62bec0e083
Fixed bug #79784
...
The fix here is essentially the same as for bug #78598 , just for
the undefined variable notice, rather than the undefined index one.
2020-07-07 14:22:58 +02:00
Christoph M. Becker
b0014adb02
[ci skip] Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
Don't use deprecated curly brace offset syntax
2020-07-07 13:56:47 +02:00
Christoph M. Becker
f23bd48892
Don't use deprecated curly brace offset syntax
...
(cherry picked from commit 7ec3aa1871 )
Better safe than sorry in case someone ever builds PHP 7.3 with a
future version of PHP SDK with bundled PHP 8.
2020-07-07 13:55:08 +02:00
Christoph M. Becker
7ec3aa1871
Don't use deprecated curly brace offset syntax
2020-07-07 13:24:41 +02:00
Nikita Popov
220880ad2d
Fixed bug #78598
...
When performing an RW modification of an array offset, the undefined
offset warning may call an error handler / OB callback, which may
destroy the array we're supposed to change. Detect this by temporarily
incrementing the reference count. If we find that the array has been
modified/destroyed in the meantime, we do nothing -- the execution
model here would be that the modification has happened on the destroyed
version of the array.
2020-07-07 12:13:58 +02:00
Nikita Popov
48a247178e
Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
Fixed bug #79792
2020-07-07 11:59:40 +02:00
Nikita Popov
64931fd3c4
Fixed bug #79792
...
We need to remove the iterators even if the array is empty (we
will not create one if the first place, but the array may become
empty after the fact).
2020-07-07 11:58:25 +02:00
Nikita Popov
6a9d934b2c
Fixed bug #79779
...
ASSIGN_OBJ_REF was not handling in zend_wrong_string_offset.
2020-07-07 10:27:22 +02:00
Nikita Popov
d9b4974cbc
Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
Fixed bug #79778
2020-07-07 10:20:11 +02:00
Nikita Popov
b765f96f5f
Fixed bug #79778
...
In the interest of avoiding side-effects during dumping, I'm
replacing the value with a <constant ast> string instead of
performing an update constant operation.
2020-07-07 10:19:39 +02:00
Nikita Popov
971e5c5186
Fixed bug #79783
...
Make sure we don't drop the by-reference check when passing the
result of a VM builtin function.
2020-07-07 09:56:14 +02:00
Christoph M. Becker
a58d865f65
Fix tests for x86 Windows
...
`st_dev` deliberately overflows on such systems, cf.
<http://svn.php.net/viewvc?view=revision&revision=350100 >.
2020-07-03 10:37:40 +02:00
Christoph M. Becker
1b961c0c42
Skip test if SeCreateSymbolicLinkPrivilege is not given
2020-07-03 09:08:59 +02:00
Christoph M. Becker
6f0b73345a
Enable readlink_realpath_* tests on Windows
...
We modify _basic1.phpt so it runs on Windows as well. The other test
cases hit the issue that `readlink()` fails normally for regular files,
but succeeds on Windows[1]. Therefore, we split these tests, but still
fix the skip reasons.
[1] <http://svn.php.net/viewvc?view=revision&revision=350097 >
2020-07-02 18:24:42 +02:00
Christoph M. Becker
1973ca21bd
Enable most lstat_stat_* tests on Windows
...
Most of these have been skipped on Windows for no good reason (`lstat`
is available there as of PHP 4). Several others would only fail,
because the `blksize` and `blocks` elements are always `-1` on Windows,
which can easily be fixed by using `%i` format specifiers instead of
`%d`.
2020-07-02 15:36:07 +02:00
Christoph M. Becker
2ecb4680ad
Update php_version.h
...
That has apparently been overlooked.
2020-07-02 15:30:13 +02:00
Christoph M. Becker
c49fb83c38
Extract test helper function for SeCreateSymbolicLinkPrivilege check
2020-07-02 12:23:49 +02:00
Nikita Popov
f1bf058d7c
Handle SO_ options only at SOL_SOCKET level
...
These options may have the same value as options at other levels.
This issue showed up on ppc64el.
2020-07-02 11:41:08 +02:00
Nikita Popov
0a216f5edb
Allow different error message for errno 58
...
Apparently this is EDEADLOCK on some systems.
2020-07-02 11:39:22 +02:00
Nikita Popov
d1be10dd7e
Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
Remove bogus generator iterator dtor
2020-06-30 17:33:33 +02:00