php/archived-php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2026-03-24 00:02:20 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge branch 'PHP-8.5'

Browse Source 
* PHP-8.5:
  Update NEWS with fix for bug #74357
  Fix bug #74357: lchown fails to change ownership of symlink with ZTS
This commit is contained in:
Jakub Zelenka
2026-01-03 14:51:26 +01:00
parent 4c9bbaa79d bddd6b0cd3
commit db65503cbc
3 changed files with 49 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Zend/zend_virtual_cwd.c
View File

@@ -1418,7 +1418,7 @@ CWD_API int virtual_chown(const char *filename, uid_t owner, gid_t group, int li
int ret;
CWD_STATE_COPY(&new_state, &CWDG(cwd));
if (virtual_file_ex(&new_state, filename, NULL, CWD_REALPATH)) {
if (virtual_file_ex(&new_state, filename, NULL, link ? CWD_EXPAND : CWD_REALPATH)) {
CWD_STATE_FREE_ERR(&new_state);
return -1;
}

32
ext/standard/tests/file/bug74357.phpt Normal file
View File

@@ -0,0 +1,32 @@
--TEST--
Bug #74357 (lchown fails to change ownership of symlink with ZTS)
--SKIPIF--
<?php
if (substr(PHP_OS, 0, 3) == 'WIN') die('skip no windows support');
if (!function_exists("posix_getpwuid")) die('skip no posix_getpwuid()');
require __DIR__ . '/../skipif_no_root.inc';
if (posix_getpwuid(1000) === false) die('skip no user with uid 1000')
?>
--FILE--
<?php
$link = __DIR__ . "/bug74357link";
$dir = __DIR__ . "bug74357dir";
if (is_link($link)) {
unlink($link);
}
if (!is_dir($dir)) {
mkdir($dir);
}
symlink($dir, $link);
lchown($link, 1000);
var_dump(lstat($link)['uid']);
?>
--CLEAN--
<?php
@unlink(__DIR__ . "/bug74357link");
@rmdir(__DIR__ . "bug74357dir");
?>
--EXPECT--
int(1000)

16
ext/standard/tests/skipif_no_root.inc Normal file
View File

@@ -0,0 +1,16 @@
<?php
// Skip if being run by root (files are always readable, writeable and executable)
$filename = @tempnam(__DIR__, 'root_check_');
if (!file_exists($filename)) {
die('WARN Unable to create the "root check" file');
}
$isRoot = fileowner($filename) == 0;
unlink($filename);
if (!$isRoot) {
die('SKIP Cannot be run as non root');
}