php/archived-php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2026-03-24 00:02:20 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fixed bug #77772

Browse Source
This commit is contained in:
Nikita Popov
2019-03-22 12:39:27 +01:00
parent a467a89f16
commit da35fa2cb8
3 changed files with 37 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
NEWS
View File

@@ -2,6 +2,9 @@ PHP NEWS
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
?? ??? 2019, PHP 7.2.18
- Reflection:
. Fixed bug #77772 (ReflectionClass::getMethods(null) doesn't work). (Nikita)
04 Apr 2019, PHP 7.2.17
- Core:

26
ext/reflection/php_reflection.c
View File

@@ -4246,15 +4246,14 @@ ZEND_METHOD(reflection_class, getMethods)
reflection_object *intern;
zend_class_entry *ce;
zend_long filter = 0;
int argc = ZEND_NUM_ARGS();
zend_bool filter_is_null = 1;
METHOD_NOTSTATIC(reflection_class_ptr);
if (argc) {
if (zend_parse_parameters(argc, "|l", &filter) == FAILURE) {
return;
}
} else {
/* No parameters given, default to "return all" */
if (zend_parse_parameters(ZEND_NUM_ARGS(), "|l!", &filter, &filter_is_null) == FAILURE) {
return;
}
if (filter_is_null) {
filter = ZEND_ACC_PPP_MASK | ZEND_ACC_ABSTRACT | ZEND_ACC_FINAL | ZEND_ACC_STATIC;
}
@@ -4442,15 +4441,14 @@ ZEND_METHOD(reflection_class, getProperties)
reflection_object *intern;
zend_class_entry *ce;
zend_long filter = 0;
int argc = ZEND_NUM_ARGS();
zend_bool filter_is_null = 1;
METHOD_NOTSTATIC(reflection_class_ptr);
if (argc) {
if (zend_parse_parameters(argc, "|l", &filter) == FAILURE) {
return;
}
} else {
/* No parameters given, default to "return all" */
if (zend_parse_parameters(ZEND_NUM_ARGS(), "|l!", &filter, &filter_is_null) == FAILURE) {
return;
}
if (filter_is_null) {
filter = ZEND_ACC_PPP_MASK | ZEND_ACC_STATIC;
}

22
ext/reflection/tests/bug77772.phpt Normal file
View File

@@ -0,0 +1,22 @@
--TEST--
Bug #77772: ReflectionClass::getMethods(null) doesn't work
--FILE--
<?php
class Test {
public $prop;
public function method() {}
}
$rc = new ReflectionClass(Test::class);
foreach ($rc->getMethods(null) as $method) {
var_dump($method->getName());
}
foreach ($rc->getProperties(null) as $prop) {
var_dump($prop->getName());
}
?>
--EXPECT--
string(6) "method"
string(4) "prop"