php/archived-php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2026-03-24 00:02:20 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix line assignment in zend_ast_create_va()

Browse Source 
The intent here was to assign the first found line. Instead this
always fell back to CG(zend_lineno).

Not sure if this line matters for anything in php-src, but the
issue was observed in https://github.com/nikic/php-ast/issues/247.
This commit is contained in:
Nikita Popov
2025-06-01 17:58:46 +02:00
parent 2ebd1258b8
commit d66e87b02e
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Zend/zend_ast.c
View File

@@ -279,7 +279,7 @@ ZEND_API zend_ast * ZEND_FASTCALL zend_ast_create_va(
ast->attr = attr;
for (uint32_t i = 0; i < children; i++) {
ast->child[i] = va_arg(*va, zend_ast *);
if (lineno != (uint32_t)-1 && ast->child[i]) {
if (lineno == (uint32_t)-1 && ast->child[i]) {
lineno = zend_ast_get_lineno(ast->child[i]);
}
}