1
0
mirror of https://github.com/php/php-src.git synced 2026-03-24 00:02:20 +01:00

Fix fallback value handling in the real-time benchmark

"{{ inputs.opcache || '1' }}" doesn't work the way I used to think: I assumed it only falls back to 1 if the input is not set (when a scheduled workflow runs). So this bug is fixed by overwriting the env vars in bash in case of manual workflows.
This commit is contained in:
Máté Kocsis
2025-08-19 08:27:40 +02:00
parent 96990f451d
commit cf33fd70ad

View File

@@ -67,11 +67,11 @@ jobs:
COMMIT: ${{ github.sha }}
BASELINE_COMMIT: "d5f6e56610c729710073350af318c4ea1b292cfe"
ID: "master"
OPCACHE: ${{ inputs.opcache || '1' }}
BASELINE_OPCACHE: ${{ inputs.baseline_opcache || '2' }}
JIT: ${{ inputs.jit || '1' }}
INSTRUCTION_COUNT: ${{ inputs.instruction_count || '1' }}
RUN_MICRO_BENCH: ${{ inputs.run_micro_bench || '0' }}
OPCACHE: "1"
BASELINE_OPCACHE: "2"
JIT: "1"
INSTRUCTION_COUNT: "1"
RUN_MICRO_BENCH: "0"
YEAR: ""
steps:
- name: Setup benchmark environment
@@ -97,6 +97,12 @@ jobs:
echo "BASELINE_COMMIT=$BASELINE_COMMIT" >> $GITHUB_ENV
echo "ID=benchmarked" >> $GITHUB_ENV
echo "OPCACHE=${{ inputs.opcache }}" >> $GITHUB_ENV
echo "BASELINE_OPCACHE=${{ inputs.baseline_opcache }}" >> $GITHUB_ENV
echo "JIT=${{ inputs.jit }}" >> $GITHUB_ENV
echo "INSTRUCTION_COUNT=${{ inputs.instruction_count }}" >> $GITHUB_ENV
echo "RUN_MICRO_BENCH=${{ inputs.run_micro_bench }}" >> $GITHUB_ENV
fi
- name: Install dependencies