php/archived-php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2026-03-24 00:02:20 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix GH-10570: Assertion `(key)->h != 0 && "Hash must be known"' failed.

Browse Source 
Fixes GH-10570, see GH-10570 for analysis.

Closes GH-10572
This commit is contained in:
Niels Dossche
2023-02-12 11:54:29 +01:00
committed by Ilija Tovilo
parent 8959ff39d8
commit b9a5bfc355
3 changed files with 17 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
NEWS
View File

@@ -14,6 +14,8 @@ PHP NEWS
. Fixed language scanner generation build. (Daniel Black)
. Fixed zend_update_static_property() calling zend_update_static_property_ex()
misleadingly with the wrong return type. (nielsdos)
. Fixed unknown string hash on property fetch with integer constant name.
(nielsdos)
- Curl:
. Fixed deprecation warning at compile time. (Max Kellermann)

14
Zend/tests/gh10570.phpt Normal file
View File

@@ -0,0 +1,14 @@
--TEST--
GH-10570 (Assertion `(key)->h != 0 && "Hash must be known"' failed.): constant variation
--FILE--
<?php
$a = new stdClass();
for ($i = 0; $i < 2; $i++) {
$a->{90};
$a->{0} = 0;
}
?>
--EXPECTF--
Warning: Undefined property: stdClass::$90 in %s on line %d
Warning: Undefined property: stdClass::$90 in %s on line %d

1
Zend/zend_compile.c
View File

@@ -2924,6 +2924,7 @@ static zend_op *zend_delayed_compile_prop(znode *result, zend_ast *ast, uint32_t
opline = zend_delayed_emit_op(result, ZEND_FETCH_OBJ_R, &obj_node, &prop_node);
if (opline->op2_type == IS_CONST) {
convert_to_string(CT_CONSTANT(opline->op2));
zend_string_hash_val(Z_STR_P(CT_CONSTANT(opline->op2)));
opline->extended_value = zend_alloc_cache_slots(3);
}