php/archived-php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2026-03-24 00:02:20 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge branch 'PHP-8.3' into PHP-8.4

Browse Source 
* PHP-8.3:
  Fix GH-20073: Assertion failure in WeakMap offset operations on reference
This commit is contained in:
Niels Dossche
2025-10-07 20:17:00 +02:00
parent 14ed8f2135 b16761ec11
commit b47c3b633d
3 changed files with 18 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
NEWS
View File

@@ -4,6 +4,8 @@ PHP NEWS
- Core:
. Fixed bug GH-19934 (CGI with auto_globals_jit=0 causes uouv). (ilutov)
. Fixed bug GH-20073 (Assertion failure in WeakMap offset operations on
reference). (nielsdos)
09 Oct 2025, PHP 8.4.14

15
Zend/tests/weakrefs/gh20073.phpt Normal file
View File

@@ -0,0 +1,15 @@
--TEST--
GH-20073 (Assertion failure in WeakMap offset operations on reference)
--FILE--
<?php
$obj = new stdClass;
$map = new WeakMap;
$integer = 1;
$map[$obj] = 0;
$map[$obj] =& $integer;
$integer++;
var_dump($map[$obj], $map->offsetGet($obj));
?>
--EXPECT--
int(2)
int(2)

2
Zend/zend_weakrefs.c
View File

@@ -722,7 +722,7 @@ ZEND_METHOD(WeakMap, offsetGet)
RETURN_THROWS();
}
ZVAL_COPY(return_value, zv);
RETURN_COPY_DEREF(zv);
}
ZEND_METHOD(WeakMap, offsetSet)