mirror of
https://github.com/php/php-src.git
synced 2026-03-24 00:02:20 +01:00
Fix parent hook call with named args
Fixes GH-20270 Closes GH-20271
This commit is contained in:
1
NEWS
1
NEWS
@@ -11,6 +11,7 @@ PHP NEWS
|
||||
. Fixed bug GH-19844 (Don't bail when closing resources on shutdown). (ilutov)
|
||||
. Fixed bug GH-20177 (Accessing overridden private property in
|
||||
get_object_vars() triggers assertion error). (ilutov)
|
||||
. Fixed bug GH-20270 (Broken parent hook call with named arguments). (ilutov)
|
||||
|
||||
- DOM:
|
||||
. Partially fixed bug GH-16317 (DOM classes do not allow
|
||||
|
||||
51
Zend/tests/property_hooks/gh20270.phpt
Normal file
51
Zend/tests/property_hooks/gh20270.phpt
Normal file
@@ -0,0 +1,51 @@
|
||||
--TEST--
|
||||
GH-20270: Parent hook call with named arguments
|
||||
--CREDITS--
|
||||
Viet Hoang Luu (@vi3tL0u1s)
|
||||
--FILE--
|
||||
<?php
|
||||
|
||||
class A {
|
||||
public mixed $prop1;
|
||||
public mixed $prop2 {
|
||||
set(mixed $custom) => $custom;
|
||||
}
|
||||
}
|
||||
|
||||
class B extends A {
|
||||
public mixed $prop1 {
|
||||
set {
|
||||
parent::$prop1::set(value: 42);
|
||||
parent::$prop1::set(unknown: 43);
|
||||
}
|
||||
}
|
||||
public mixed $prop2 {
|
||||
set {
|
||||
parent::$prop2::set(custom: 42);
|
||||
parent::$prop2::set(value: 43);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
$b = new B();
|
||||
|
||||
try {
|
||||
$b->prop1 = 0;
|
||||
} catch (Error $e) {
|
||||
echo $e->getMessage(), "\n";
|
||||
}
|
||||
var_dump($b->prop1);
|
||||
|
||||
try {
|
||||
$b->prop2 = 0;
|
||||
} catch (Error $e) {
|
||||
echo $e->getMessage(), "\n";
|
||||
}
|
||||
var_dump($b->prop2);
|
||||
|
||||
?>
|
||||
--EXPECT--
|
||||
Unknown named parameter $unknown
|
||||
int(42)
|
||||
Unknown named parameter $value
|
||||
int(42)
|
||||
@@ -1783,7 +1783,9 @@ ZEND_API zend_function *zend_get_property_hook_trampoline(
|
||||
const zend_property_info *prop_info,
|
||||
zend_property_hook_kind kind, zend_string *prop_name)
|
||||
{
|
||||
static const zend_arg_info arg_info[1] = {{0}};
|
||||
static const zend_internal_arg_info arg_info[2] = {
|
||||
{ .name = "value" }
|
||||
};
|
||||
zend_function *func;
|
||||
if (EXPECTED(EG(trampoline).common.function_name == NULL)) {
|
||||
func = &EG(trampoline);
|
||||
|
||||
Reference in New Issue
Block a user