php/archived-php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2026-04-12 18:43:37 +02:00
Code Issues Packages Projects Releases Wiki Activity

Check for redundant func info

Browse Source
This commit is contained in:
Nikita Popov
2020-07-21 11:10:53 +02:00
parent ac56ca0dcc
commit ae2b214be2
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
ext/opcache/Optimizer/zend_func_info.c
View File

@@ -938,6 +938,11 @@ uint32_t zend_get_func_info(
if (internal_ret & ~ret) {
fprintf(stderr, "Inaccurate func info for %s()\n", ZSTR_VAL(lcname));
}
/* Check whether the func info is completely redundant with arginfo.
* Ignore UNKNOWN_INFO for now. */
if (internal_ret == ret && (internal_ret & MAY_BE_ANY) != MAY_BE_ANY) {
fprintf(stderr, "Useless func info for %s()\n", ZSTR_VAL(lcname));
}
/* If the return type is not mixed, check that the types match exactly if we exclude
* RC and array information. */
uint32_t ret_any = ret & MAY_BE_ANY, internal_ret_any = internal_ret & MAY_BE_ANY;