php/archived-php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2026-03-24 00:02:20 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge branch 'PHP-8.5'

Browse Source 
* PHP-8.5:
  Fix parent hook call with named args
This commit is contained in:
Ilija Tovilo
2025-10-27 16:39:20 +01:00
parent 64b30cee76 a1911ad3ef
commit 932241f2b5
2 changed files with 54 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

51
Zend/tests/property_hooks/gh20270.phpt Normal file
View File

@@ -0,0 +1,51 @@
--TEST--
GH-20270: Parent hook call with named arguments
--CREDITS--
Viet Hoang Luu (@vi3tL0u1s)
--FILE--
<?php
class A {
public mixed $prop1;
public mixed $prop2 {
set(mixed $custom) => $custom;
}
}
class B extends A {
public mixed $prop1 {
set {
parent::$prop1::set(value: 42);
parent::$prop1::set(unknown: 43);
}
}
public mixed $prop2 {
set {
parent::$prop2::set(custom: 42);
parent::$prop2::set(value: 43);
}
}
}
$b = new B();
try {
$b->prop1 = 0;
} catch (Error $e) {
echo $e->getMessage(), "\n";
}
var_dump($b->prop1);
try {
$b->prop2 = 0;
} catch (Error $e) {
echo $e->getMessage(), "\n";
}
var_dump($b->prop2);
?>
--EXPECT--
Unknown named parameter $unknown
int(42)
Unknown named parameter $value
int(42)

4
Zend/zend_object_handlers.c
View File

@@ -1788,7 +1788,9 @@ ZEND_API zend_function *zend_get_property_hook_trampoline(
const zend_property_info *prop_info,
zend_property_hook_kind kind, zend_string *prop_name)
{
static const zend_arg_info arg_info[1] = {{0}};
static const zend_internal_arg_info arg_info[2] = {
{ .name = "value" }
};
zend_function *func;
if (EXPECTED(EG(trampoline).common.function_name == NULL)) {
func = &EG(trampoline);