php/archived-php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2026-03-26 01:02:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

Bug #6016: Fix EBCDIC logic error in urlencode()

Browse Source 
(a strchr() test was used backwards)
Reported by: dumbunny@tivo.com
This commit is contained in:
Martin Kraemer
2000-08-08 09:06:51 +00:00
parent e31a7fcdfc
commit 8bf2339870
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
ext/standard/url.c
View File

@@ -253,7 +253,8 @@ char *php_url_encode(char *s, int len)
str[y] = hexchars[(unsigned char) s[x] & 15];
}
#else /*CHARSET_EBCDIC*/
} else if (!isalnum(str[y]) && strchr("_-.", str[y]) != NULL) {
} else if (!isalnum(str[y]) && strchr("_-.", str[y]) == NULL) {
/* Allow only alphanumeric chars and '_', '-', '.'; escape the rest */
str[y++] = '%';
str[y++] = hexchars[os_toascii[(unsigned char) s[x]] >> 4];
str[y] = hexchars[os_toascii[(unsigned char) s[x]] & 0x0F];