php/archived-php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2026-03-24 08:12:21 +01:00
Code Issues Packages Projects Releases Wiki Activity

Don't truncate subsecond precision in run-tests.php JUNIT output

Browse Source 
When run-tests.php has been typed[1], the type of `$time` has been
chosen to be `int`.  This, however, leads to truncation, and the
somewhat relevant subsecond precision is lost.  We fix that by
changing the type to `float`, although `int|string` would be more
appropriate, but requires PHP ≥ 7.4.0.  Another option would be to
move the `number_format()` formatting into `junit_mark_test_as()`.

[1] <11274f53e7>

Closes GH-7836.
This commit is contained in:
Christoph M. Becker
2021-12-27 13:44:53 +01:00
parent ee610947ce
commit 87d9e02f01
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
run-tests.php
View File

@@ -3478,7 +3478,7 @@ function junit_mark_test_as(
$type,
string $file_name,
string $test_name,
?int $time = null,
?float $time = null,
string $message = '',
string $details = ''
): void {
@@ -3533,7 +3533,7 @@ function junit_mark_test_as(
$JUNIT['files'][$file_name]['xml'] .= "</testcase>\n";
}
function junit_suite_record(string $suite, string $param, int $value = 1): void
function junit_suite_record(string $suite, string $param, float $value = 1): void
{
global $JUNIT;
@@ -3541,7 +3541,7 @@ function junit_suite_record(string $suite, string $param, int $value = 1): void
$JUNIT['suites'][$suite][$param] += $value;
}
function junit_get_timer(string $file_name): int
function junit_get_timer(string $file_name): float
{
global $JUNIT;
if (!junit_enabled()) {