php/archived-php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2026-03-27 01:32:22 +01:00
Code Issues Packages Projects Releases Wiki Activity

MFB: Fixed bug #44836 (putenv() crashes, avoid direct reference of environ

Browse Source 
in POSIX systems).
This commit is contained in:
Ilia Alshanetsky
2008-05-06 18:04:25 +00:00
parent ad9b3c053b
commit 7e68effe43
1 changed files with 1 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
ext/standard/basic_functions.c
View File

@@ -3822,9 +3822,7 @@ static void php_putenv_destructor(putenv_entry *pe) /* {{{ */
SetEnvironmentVariable(pe->key, "bugbug");
#endif
putenv(pe->previous_value);
# if defined(PHP_WIN32)
efree(pe->previous_value);
# endif
} else {
# if HAVE_UNSETENV
unsetenv(pe->key);
@@ -4388,12 +4386,8 @@ PHP_FUNCTION(putenv)
pe.previous_value = NULL;
for (env = environ; env != NULL && *env != NULL; env++) {
if (!strncmp(*env, pe.key, pe.key_len) && (*env)[pe.key_len] == '=') { /* found it */
#if defined(PHP_WIN32)
/* must copy previous value because MSVCRT's putenv can free the string without notice */
/* must copy previous value because putenv can free the string without notice */
pe.previous_value = estrdup(*env);
#else
pe.previous_value = *env;
#endif
break;
}
}