php/archived-php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2026-03-24 00:02:20 +01:00
Code Issues Packages Projects Releases Wiki Activity

gen_stub: add ConstInfo::getPredefinedConstantElement()

Browse Source 
Simplifies the implementation of `::getPredefinedConstantTerm()` and
`::getPredefinedConstantEntry()`, which only differ in the name of the tag
used.
This commit is contained in:
Daniel Scherzer
2025-05-15 15:37:06 -04:00
parent 5ae87ffef4
commit 74f7ecbe04
1 changed files with 17 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
build/gen_stub.php
View File

@@ -2672,41 +2672,35 @@ class ConstInfo extends VariableLike
return $this->valueString;
}
public function getPredefinedConstantTerm(DOMDocument $doc, int $indentationLevel): DOMElement {
private function getPredefinedConstantElement(
DOMDocument $doc,
int $indentationLevel,
string $name
): DOMElement {
$indentation = str_repeat(" ", $indentationLevel);
$termElement = $doc->createElement("term");
$element = $doc->createElement($name);
$constantElement = $doc->createElement("constant");
$constantElement->textContent = $this->name->__toString();
$typeElement = ($this->phpDocType ?? $this->type)->getTypeForDoc($doc);
$termElement->appendChild(new DOMText("\n$indentation "));
$termElement->appendChild($constantElement);
$termElement->appendChild(new DOMText("\n$indentation ("));
$termElement->appendChild($typeElement);
$termElement->appendChild(new DOMText(")\n$indentation"));
$element->appendChild(new DOMText("\n$indentation "));
$element->appendChild($constantElement);
$element->appendChild(new DOMText("\n$indentation ("));
$element->appendChild($typeElement);
$element->appendChild(new DOMText(")\n$indentation"));
return $termElement;
return $element;
}
public function getPredefinedConstantTerm(DOMDocument $doc, int $indentationLevel): DOMElement {
return $this->getPredefinedConstantElement($doc, $indentationLevel, "term");
}
public function getPredefinedConstantEntry(DOMDocument $doc, int $indentationLevel): DOMElement {
$indentation = str_repeat(" ", $indentationLevel);
$entryElement = $doc->createElement("entry");
$constantElement = $doc->createElement("constant");
$constantElement->textContent = $this->name->__toString();
$typeElement = ($this->phpDocType ?? $this->type)->getTypeForDoc($doc);
$entryElement->appendChild(new DOMText("\n$indentation "));
$entryElement->appendChild($constantElement);
$entryElement->appendChild(new DOMText("\n$indentation ("));
$entryElement->appendChild($typeElement);
$entryElement->appendChild(new DOMText(")\n$indentation"));
return $entryElement;
return $this->getPredefinedConstantElement($doc, $indentationLevel, "entry");
}
public function discardInfoForOldPhpVersions(?int $phpVersionIdMinimumCompatibility): void {