php/archived-php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2026-03-24 00:02:20 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge branch 'PHP-8.3' into PHP-8.4

Browse Source 
* PHP-8.3:
  Fix GH-20602: imagescale() overflow with large height values.
This commit is contained in:
David Carlier
2025-11-29 13:31:38 +00:00
parent 159a75c93c c8e13af455
commit 6d5490861f
3 changed files with 32 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
NEWS
View File

@@ -31,6 +31,8 @@ PHP NEWS
- GD:
. Fixed bug GH-20511 (imagegammacorrect out of range input/output values).
(David Carlier)
. Fixed bug GH-20602 (imagescale overflow with large height values).
(David Carlier)
- LibXML:
. Fix some deprecations on newer libxml versions regarding input

8
ext/gd/gd.c
View File

@@ -4042,9 +4042,17 @@ PHP_FUNCTION(imagescale)
src_y = gdImageSY(im);
if (src_x && tmp_h < 0) {
if (tmp_w > (ZEND_LONG_MAX / src_y)) {
zend_argument_value_error(2, "must be less than or equal to " ZEND_LONG_FMT, (zend_long)(ZEND_LONG_MAX / src_y));
RETURN_THROWS();
}
tmp_h = tmp_w * src_y / src_x;
}
if (src_y && tmp_w < 0) {
if (tmp_h > (ZEND_LONG_MAX / src_x)) {
zend_argument_value_error(3, "must be less than or equal to " ZEND_LONG_FMT, (zend_long)(ZEND_LONG_MAX / src_x));
RETURN_THROWS();
}
tmp_w = tmp_h * src_x / src_y;
}
}

22
ext/gd/tests/gh20602.phpt Normal file
View File

@@ -0,0 +1,22 @@
--TEST--
GH-20551: (imagegammacorrect out of range input/output value)
--EXTENSIONS--
gd
--FILE--
<?php
$im = imagecreatetruecolor(16, 16);
try {
imagescale($im, PHP_INT_MAX, -1);
} catch (\ValueError $e) {
echo $e->getMessage(), PHP_EOL;
}
try {
imagescale($im, -1, PHP_INT_MAX);
} catch (\ValueError $e) {
echo $e->getMessage(), PHP_EOL;
}
?>
--EXPECTF--
imagescale(): Argument #2 ($width) must be less than or equal to %d
imagescale(): Argument #3 ($height) must be less than or equal to %d