php/archived-php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2026-04-14 19:41:05 +02:00
Code Issues Packages Projects Releases Wiki Activity

Remove redundant htmlentities() tests

Browse Source 
Test 04 and 15 are the same as 02 and 03, just for different
encodings. They don't add value, but their execution depends
on available locales, so they're easy to miss...
This commit is contained in:
Nikita Popov
2020-05-07 18:36:48 +02:00
parent 5d8cf36022
commit 5ef65dd114
2 changed files with 0 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
ext/standard/tests/strings/htmlentities04.phpt
View File

@@ -1,21 +0,0 @@
--TEST--
htmlentities() test 4 (setlocale / ja_JP.EUC-JP)
--SKIPIF--
<?php
$result = (bool)setlocale(LC_CTYPE, "ja_JP.EUC-JP", "ja_JP.eucJP");
if (!$result || preg_match('/EUC[^a-zA-Z]*JP/i', setlocale(LC_CTYPE, 0)) == 0) {
die("skip setlocale() failed\n");
}
?>
--INI--
output_handler=
default_charset=
internal_encoding=pass
--FILE--
<?php
setlocale( LC_CTYPE, "ja_JP.EUC-JP", "ja_JP.eucJP" );
var_dump(htmlentities("\xa1\xa2\xa1\xa3\xa1\xa4", ENT_QUOTES, ''));
?>
--EXPECTF--
Notice: htmlentities(): Only basic entities substitution is supported for multi-byte encodings other than UTF-8; functionality is equivalent to htmlspecialchars in %s line %d
string(6) "¡¢¡£¡¤"

25
ext/standard/tests/strings/htmlentities15.phpt
View File

@@ -1,25 +0,0 @@
--TEST--
htmlentities() test 15 (setlocale / KOI8-R)
--INI--
output_handler=
default_charset=
internal_encoding=pass
--SKIPIF--
<?php
$result = (bool)setlocale(LC_CTYPE, "ru_RU.koi8r", "ru_RU.KOI8-R");
if (!$result || preg_match('/koi8/i', setlocale(LC_CTYPE, 0)) == 0) {
die("skip setlocale() failed\n");
}
?>
--DESCRIPTION--
As of PHP 5.4, htmlentities() no longer makes replacements with numerical
entities. Hence, for this input there's no substitution.
--FILE--
<?php
setlocale(LC_CTYPE, "ru_RU.koi8r", "ru_RU.KOI8-R");
$str = "ÒÏÓËÏÛÎÙÊ";
var_dump($str, htmlentities($str, ENT_QUOTES, ''));
?>
--EXPECT--
string(9) "ÒÏÓËÏÛÎÙÊ"
string(9) "ÒÏÓËÏÛÎÙÊ"