php/archived-php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2026-03-24 00:02:20 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge branch 'PHP-8.1'

Browse Source 
* PHP-8.1:
  Fixed bug GH-8943 Reflection::getModifiersNames() with readonly modifier
This commit is contained in:
Pierrick Charron
2022-07-07 17:03:25 -04:00
parent caa13aff5d c650e67c90
commit 4dd66b8ce0
2 changed files with 29 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
ext/reflection/php_reflection.c
View File

@@ -1559,6 +1559,10 @@ ZEND_METHOD(Reflection, getModifierNames)
if (modifiers & ZEND_ACC_STATIC) {
add_next_index_stringl(return_value, "static", sizeof("static")-1);
}
if (modifiers & (ZEND_ACC_READONLY | ZEND_ACC_READONLY_CLASS)) {
add_next_index_stringl(return_value, "readonly", sizeof("readonly")-1);
}
}
/* }}} */

25
ext/reflection/tests/Reflection_getModifierNames_001.phpt Normal file
View File

@@ -0,0 +1,25 @@
--TEST--
Reflection::getModifierNames() basic
--FILE--
<?php
function printModifiers($modifiers) {
echo implode(',', Reflection::getModifierNames($modifiers)), PHP_EOL;
}
printModifiers(ReflectionProperty::IS_PRIVATE);
printModifiers(ReflectionProperty::IS_PROTECTED | ReflectionProperty::IS_STATIC);
printModifiers(ReflectionProperty::IS_PUBLIC | ReflectionProperty::IS_READONLY);
printModifiers(ReflectionClass::IS_EXPLICIT_ABSTRACT);
printModifiers(ReflectionMethod::IS_ABSTRACT | ReflectionMethod::IS_FINAL);
printModifiers(ReflectionProperty::IS_PUBLIC | ReflectionProperty::IS_STATIC | ReflectionProperty::IS_READONLY);
printModifiers(ReflectionClass::IS_READONLY);
?>
--EXPECT--
private
protected,static
public,readonly
abstract
abstract,final
public,static,readonly
readonly