1
0
mirror of https://github.com/php/php-src.git synced 2026-03-24 00:02:20 +01:00

Merge branch 'PHP-8.3' into PHP-8.4

* PHP-8.3:
  Partially fix GH-16317: DOM classes do not allow __debugInfo() overrides to work
This commit is contained in:
Niels Dossche
2025-10-13 18:44:57 +02:00
3 changed files with 30 additions and 0 deletions

4
NEWS
View File

@@ -9,6 +9,10 @@ PHP NEWS
. Fixed bug GH-20085 (Assertion failure when combining lazy object
get_properties exception with foreach loop). (nielsdos)
- DOM:
. Partially fixed bug GH-16317 (DOM classes do not allow
__debugInfo() overrides to work). (nielsdos)
- FPM:
. Fixed bug GH-19974 (fpm_status_export_to_zval segfault for parallel
execution). (Jakub Zelenka, txuna)

View File

@@ -492,6 +492,7 @@ static void dom_unset_property(zend_object *object, zend_string *member, void **
zend_std_unset_property(object, member, cache_slot);
}
/* This custom handler is necessary to avoid a recursive construction of the entire subtree. */
static HashTable* dom_get_debug_info_helper(zend_object *object, int *is_temp) /* {{{ */
{
dom_object *obj = php_dom_obj_from_obj(object);
@@ -502,6 +503,11 @@ static HashTable* dom_get_debug_info_helper(zend_object *object, int *is_temp) /
dom_prop_handler *entry;
zend_string *object_str;
/* As we have a custom implementation, we must manually check for overrides. */
if (object->ce->__debugInfo) {
return zend_std_get_debug_info(object, is_temp);
}
*is_temp = 1;
std_props = zend_std_get_properties(object);

View File

@@ -0,0 +1,20 @@
--TEST--
GH-16317 (DOM classes do not allow __debugInfo() overrides to work)
--FILE--
<?php
class Demo extends DOMNode {
public function __construct() {}
public function __debugInfo(): array {
return ['x' => 'y'];
}
}
var_dump(new Demo());
?>
--EXPECT--
object(Demo)#1 (1) {
["x"]=>
string(1) "y"
}