php/archived-php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2026-03-31 04:32:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

s/isFlushing/isFlushingToPhar much clearer purpose in method name

Browse Source
This commit is contained in:
Greg Beaver
2007-02-03 00:45:24 +00:00
parent 696e85f062
commit 340e9b24fc
2 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
ext/phar/phar_object.c
View File

@@ -225,14 +225,14 @@ PHP_METHOD(Phar, begin)
}
/* }}} */
/* {{{ proto bool Phar::isFlushing()
/* {{{ proto bool Phar::isFlushingToPhar()
* Returns whether write operations are flushing to disk immediately
*/
PHP_METHOD(Phar, isFlushing)
PHP_METHOD(Phar, isFlushingToPhar)
{
PHAR_ARCHIVE_OBJECT();
RETURN_BOOL(!phar_obj->arc.archive->donotflush);
RETURN_BOOL(phar_obj->arc.archive->donotflush);
}
/* }}} */
@@ -1105,7 +1105,7 @@ zend_function_entry php_archive_methods[] = {
PHP_ME(Phar, getSignature, NULL, ZEND_ACC_PUBLIC)
PHP_ME(Phar, getStub, NULL, ZEND_ACC_PUBLIC)
PHP_ME(Phar, getVersion, NULL, ZEND_ACC_PUBLIC)
PHP_ME(Phar, isFlushing, NULL, ZEND_ACC_PUBLIC)
PHP_ME(Phar, isFlushingToPhar, NULL, ZEND_ACC_PUBLIC)
PHP_ME(Phar, setMetadata, arginfo_entry_setMetadata, ZEND_ACC_PUBLIC)
PHP_ME(Phar, setStub, arginfo_phar_setStub, ZEND_ACC_PUBLIC)
PHP_ME(Phar, offsetExists, arginfo_phar_offsetExists, ZEND_ACC_PUBLIC)

10
ext/phar/tests/phar_begin_setstub_commit.phpt
View File

@@ -9,9 +9,9 @@ phar.readonly=0
<?php
$p = new Phar(dirname(__FILE__) . '/brandnewphar.phar', 0, 'brandnewphar.phar');
//var_dump($p->getStub());
var_dump($p->isFlushing());
var_dump($p->inTransaction());
$p->begin();
var_dump($p->isFlushing());
var_dump($p->inTransaction());
$p['a.php'] = '<?php var_dump("Hello");';
$p->setStub('<?php var_dump("First"); Phar::mapPhar("brandnewphar.phar"); __HALT_COMPILER(); ?>');
include 'phar://brandnewphar.phar/a.php';
@@ -22,7 +22,7 @@ include 'phar://brandnewphar.phar/b.php';
var_dump($p->getStub());
$p->commit();
echo "===COMMIT===\n";
var_dump($p->isFlushing());
var_dump($p->inTransaction());
include 'phar://brandnewphar.phar/a.php';
include 'phar://brandnewphar.phar/b.php';
var_dump($p->getStub());
@@ -33,14 +33,14 @@ var_dump($p->getStub());
unlink(dirname(__FILE__) . '/brandnewphar.phar');
?>
--EXPECT--
bool(true)
bool(false)
bool(true)
string(5) "Hello"
string(82) "<?php var_dump("First"); Phar::mapPhar("brandnewphar.phar"); __HALT_COMPILER(); ?>"
string(5) "World"
string(83) "<?php var_dump("Second"); Phar::mapPhar("brandnewphar.phar"); __HALT_COMPILER(); ?>"
===COMMIT===
bool(true)
bool(false)
string(5) "Hello"
string(5) "World"
string(83) "<?php var_dump("Second"); Phar::mapPhar("brandnewphar.phar"); __HALT_COMPILER(); ?>"