php/archived-php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2026-03-24 00:02:20 +01:00
Code Issues Packages Projects Releases Wiki Activity

Drop FIXME in pcntl_signal_dispatch() (#18633)

Browse Source
This commit is contained in:
Niels Dossche
2025-05-24 14:35:32 +02:00
committed by GitHub
parent dfff6ac852
commit 2a9ea2c9f5
1 changed files with 0 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
ext/pcntl/pcntl.c
View File

@@ -1356,7 +1356,6 @@ void pcntl_signal_dispatch(void)
while (queue) {
if ((handle = zend_hash_index_find(&PCNTL_G(php_signal_table), queue->signo)) != NULL) {
if (Z_TYPE_P(handle) != IS_LONG) {
ZVAL_NULL(&retval);
ZVAL_LONG(&params[0], queue->signo);
#ifdef HAVE_STRUCT_SIGINFO_T
array_init(&params[1]);
@@ -1366,7 +1365,6 @@ void pcntl_signal_dispatch(void)
#endif
/* Call php signal handler - Note that we do not report errors, and we ignore the return value */
/* FIXME: this is probably broken when multiple signals are handled in this while loop (retval) */
call_user_function(NULL, NULL, handle, &retval, 2, params);
zval_ptr_dtor(&retval);
#ifdef HAVE_STRUCT_SIGINFO_T