php/archived-php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2026-04-26 09:28:21 +02:00
Code Issues Packages Projects Releases Wiki Activity

We shouldn't modify strings in-place (it may be interned strings stored in SHN)

Browse Source
This commit is contained in:
Dmitry Stogov
2014-05-07 23:19:28 +04:00
parent d41d6cf206
commit 223df9ceea
1 changed files with 1 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ext/pdo/pdo_dbh.c
+1 -4
View File
@@ -208,7 +208,6 @@ static PHP_METHOD(PDO, dbh_constructor)
zval *options = NULL;
char alt_dsn[512];
int call_factory = 1;
char tmp;
if (FAILURE == zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "s|s!s!a!", &data_source, &data_source_len,
&username, &usernamelen, &password, &passwordlen, &options)) {
@@ -256,10 +255,8 @@ static PHP_METHOD(PDO, dbh_constructor)
}
}
tmp = data_source[colon - data_source];
data_source[colon - data_source] = '\0';
driver = pdo_find_driver(data_source, colon - data_source);
data_source[colon - data_source] = tmp;
if (!driver) {
/* NB: don't want to include the data_source in the error message as
* it might contain a password */