php/archived-php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2026-04-27 01:48:26 +02:00
Code Issues Packages Projects Releases Wiki Activity

removed ->is_ref check, doesn't make sense and causes bugs

Browse Source
This commit is contained in:
Harald Radi
2001-09-10 09:25:32 +00:00
parent d1a2dbfd9d
commit 21b9a2ca2a
4 changed files with 26 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ext/com/TODO
+12 -4
View File
@@ -1,5 +1,5 @@
1) Multi-dimenstional array support
2) IErrorInfo
-- done 2) IErrorInfo
3) WithEvents
4) Documentation (internal and user) and howtos
5) IEnumVariant::All() which would be like IEnumVariant::Next(IDispatch::Count)
@@ -8,9 +8,17 @@
8) Test suite (Needs test component)
9) reduce the need for VARIANT()
10) lets try if we are able to call non IDispatch - only Typelib components
11) IEnumVariant::Next() without parameter should only return an object, not an array with one element
-- done 11) IEnumVariant::Next() without parameter should only return an object, not an array with one element
12) VARIANT->value as lvalue
these seem to be done:
ad 6.) check vbsample.php (new VARIANT(*, *|VT_BYREF)) GPs
ad 4.) faq (i've collected a few questions from various lists)
2) 6) 11)
to be discussed:
- dcom inporc issue
- mts support (getcontext)
- adsi support (ads* functions)
- winapi interface
- try serialisation support (if component implements IPersist)
ext/com/conversion.c
+1 -1
View File
@@ -86,7 +86,7 @@ PHPAPI void php_pval_to_variant(pval *pval_arg, VARIANT *var_arg, int codepage T
}
if (pval_arg->is_ref) { /* deprecated, implemented for downwards compatiblity */
type |= VT_BYREF;
// type |= VT_BYREF;
}
pval_to_variant_ex(pval_arg, var_arg, type, codepage TSRMLS_CC);
ext/rpc/com/TODO
+12 -4
View File
@@ -1,5 +1,5 @@
1) Multi-dimenstional array support
2) IErrorInfo
-- done 2) IErrorInfo
3) WithEvents
4) Documentation (internal and user) and howtos
5) IEnumVariant::All() which would be like IEnumVariant::Next(IDispatch::Count)
@@ -8,9 +8,17 @@
8) Test suite (Needs test component)
9) reduce the need for VARIANT()
10) lets try if we are able to call non IDispatch - only Typelib components
11) IEnumVariant::Next() without parameter should only return an object, not an array with one element
-- done 11) IEnumVariant::Next() without parameter should only return an object, not an array with one element
12) VARIANT->value as lvalue
these seem to be done:
ad 6.) check vbsample.php (new VARIANT(*, *|VT_BYREF)) GPs
ad 4.) faq (i've collected a few questions from various lists)
2) 6) 11)
to be discussed:
- dcom inporc issue
- mts support (getcontext)
- adsi support (ads* functions)
- winapi interface
- try serialisation support (if component implements IPersist)
ext/rpc/com/conversion.c
+1 -1
View File
@@ -86,7 +86,7 @@ PHPAPI void php_pval_to_variant(pval *pval_arg, VARIANT *var_arg, int codepage T
}
if (pval_arg->is_ref) { /* deprecated, implemented for downwards compatiblity */
type |= VT_BYREF;
// type |= VT_BYREF;
}
pval_to_variant_ex(pval_arg, var_arg, type, codepage TSRMLS_CC);