php/archived-php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2026-03-24 00:02:20 +01:00
Code Issues Packages Projects Releases Wiki Activity

simplexml: Avoid double lookups and unnecessary allocations in getNamespaces() (#20447)

Browse Source
This commit is contained in:
Niels Dossche
2025-11-11 11:19:29 +01:00
committed by GitHub
parent 4227106f37
commit 08ba240c81
1 changed files with 3 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
ext/simplexml/simplexml.c
View File

@@ -1413,14 +1413,10 @@ PHP_METHOD(SimpleXMLElement, asXML)
static inline void sxe_add_namespace_name_raw(zval *return_value, const char *prefix, const char *href)
{
zend_string *key = zend_string_init(prefix, strlen(prefix), 0);
zval zv;
if (!zend_hash_exists(Z_ARRVAL_P(return_value), key)) {
ZVAL_STRING(&zv, href);
zend_hash_add_new(Z_ARRVAL_P(return_value), key, &zv);
zval *zv = zend_hash_str_lookup(Z_ARRVAL_P(return_value), prefix, strlen(prefix));
if (Z_ISNULL_P(zv)) {
ZVAL_STRING(zv, href);
}
zend_string_release_ex(key, 0);
}
static inline void sxe_add_namespace_name(zval *return_value, xmlNsPtr ns) /* {{{ */