php/archived-php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2026-04-26 09:28:21 +02:00
Code Issues Packages Projects Releases Wiki Activity

changed the error checks on result set retrieval

Browse Source 
UPDATEs not modifying anything are not actually bugs
This commit is contained in:
Hartmut Holzgraefe
2005-02-27 12:15:47 +00:00
parent 81770f3c39
commit 04f2f981e0
1 changed files with 18 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ext/pdo_mysql/mysql_statement.c
+18 -7
View File
@@ -48,6 +48,7 @@ static int pdo_mysql_stmt_execute(pdo_stmt_t *stmt TSRMLS_DC)
{
pdo_mysql_stmt *S = (pdo_mysql_stmt*)stmt->driver_data;
pdo_mysql_db_handle *H = S->H;
my_ulonglong row_count;
/* ensure that we free any previous unfetched results */
if (S->result) {
@@ -59,17 +60,27 @@ static int pdo_mysql_stmt_execute(pdo_stmt_t *stmt TSRMLS_DC)
pdo_mysql_error_stmt(stmt);
return 0;
}
if ((S->result = mysql_use_result(H->server)) == NULL) {
/* could've been INSERT/UPDATE/DELETE query */
if (!mysql_affected_rows(H->server)) {
row_count = mysql_affected_rows(H->server);
if (row_count == (my_ulonglong)-1) {
// we either have a query that returned a result set or an error occured
// lets see if we have access to a result set
S->result = mysql_use_result(H->server);
if (NULL == S->result) {
pdo_mysql_error_stmt(stmt);
return 0;
}
return 1;
}
if (!stmt->executed) {
stmt->column_count = (int) mysql_num_fields(S->result);
stmt->row_count = 0;
if (!stmt->executed) {
stmt->column_count = (int) mysql_num_fields(S->result);
}
} else {
// this was a DML or DDL query (INSERT, UPDATE, DELETE, ...
stmt->row_count = row_count;
}
return 1;
}