php/archived-pecl-tools-svn
1
0
Fork 0
mirror of https://github.com/php/pecl-tools-svn.git synced 2026-03-23 23:12:26 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix #68441: wrong ZPP for svn_diff()

Browse Source 
If a `zend_long` parameter is nullable, it needs an additional
`zend_bool` argument which indicates whether the passed argument
actually was `NULL`; otherwise the parameter memory will be corrupted.

Since the default value of these parameters is `SVN_REVISION_HEAD`
anyway, there is no need for the parameters to be nullable at all.
This also matches the "proto" and the docs.  This is also not a real
BC break, since passing `NULL` to these parameters likely crashes
anyway.

The patch has been provided by the bug reporter.

Closes GH-1.
This commit is contained in:
Christoph M. Becker
2021-09-17 12:34:58 +02:00
committed by GitHub
parent 46c0732c80
commit eb514b679d
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
svn.c
View File

@@ -1345,7 +1345,7 @@ PHP_FUNCTION(svn_diff)
svn_opt_revision_t revision1, revision2;
zend_bool ignore_content_type = 0;
if (FAILURE == zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "sl!sl!",
if (FAILURE == zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "slsl",
&path1, &path1len, &rev1,
&path2, &path2len, &rev2)) {
return;