php/archived-pecl-numbers-bitset
1
0
Fork 0
mirror of https://github.com/php/pecl-numbers-bitset.git synced 2026-03-23 23:42:23 +01:00
Code Issues Packages Projects Releases Wiki Activity

avoid double allocation

Browse Source
This commit is contained in:
Remi Collet
2023-05-26 15:54:12 +02:00
parent 25ddddbcc2
commit 30a30e62d3
1 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
bitset.c
View File

@@ -803,7 +803,7 @@ PHP_METHOD(BitSet, __toString)
{
php_bitset_object *intern = NULL;
zend_string *retval;
unsigned char *internval = NULL;
char *internval = NULL;
long len, i;
if (zend_parse_parameters_none() == FAILURE) {
@@ -816,16 +816,14 @@ PHP_METHOD(BitSet, __toString)
RETURN_EMPTY_STRING();
} else {
len = intern->bitset_len * CHAR_BIT;
internval = (unsigned char *) emalloc(len + 1);
retval = zend_string_alloc(len, 0);
internval = ZSTR_VAL(retval);
internval[len] = '\0';
for (i = 0; i < len; i++) {
internval[i] = ((intern->bitset_val[i / CHAR_BIT] >> (i % CHAR_BIT)) & 1) ? '1' : '0';
}
retval = zend_string_init((const char *) internval, strlen((const char *) internval), 0);
efree(internval);
RETURN_STR(retval);
}
}