php/archived-pecl-networking-ssh2
1
0
Fork 0
mirror of https://github.com/php/pecl-networking-ssh2.git synced 2026-03-23 22:52:06 +01:00
Code Issues Packages Projects Releases Wiki Activity

Call return value destructor for unused return value

Browse Source
This commit is contained in:
Casper Langemeijer
2021-02-25 21:02:09 +01:00
parent efcc6cb45d
commit dfea519a82
1 changed files with 12 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
ssh2.c
View File

@@ -96,9 +96,14 @@ LIBSSH2_DEBUG_FUNC(php_ssh2_debug_cb)
ZVAL_STRINGL(&args[1], language, language_len);
ZVAL_LONG(&args[2], always_display);
if (FAILURE == call_user_function(NULL, NULL, data->debug_cb, NULL, 3, args)) {
zval retval;
if (FAILURE == call_user_function(NULL, NULL, data->debug_cb, &retval, 3, args)) {
php_error_docref(NULL, E_WARNING, "Failure calling debug callback");
}
if (!Z_ISUNDEF(retval)) {
zval_ptr_dtor(&retval);
}
}
/* }}} */
@@ -184,9 +189,14 @@ LIBSSH2_DISCONNECT_FUNC(php_ssh2_disconnect_cb)
ZVAL_STRINGL(&args[1], message, message_len);
ZVAL_STRINGL(&args[2], language, language_len);
if (FAILURE == call_user_function(NULL, NULL, data->disconnect_cb, NULL, 3, args)) {
zval retval;
if (FAILURE == call_user_function(NULL, NULL, data->disconnect_cb, &retval, 3, args)) {
php_error_docref(NULL, E_WARNING, "Failure calling disconnect callback");
}
if (!Z_ISUNDEF(retval)) {
zval_ptr_dtor(&retval);
}
}
/* }}} */