php/archived-frankenphp
1
0
Fork 0
mirror of https://github.com/php/frankenphp.git synced 2026-03-24 00:52:11 +01:00
Code Issues Packages Projects Releases Wiki Activity

perf: avoid extra string allocation in get_full_env() (#1382)

Browse Source 
* Avoid extra string allocation in get_full_env()

We can pass the key directly to add_assoc_str().

* Use add_assoc_str_ex
This commit is contained in:
Niels Dossche
2025-02-18 09:11:23 +01:00
committed by GitHub
parent f61bc180c4
commit 30bf69cbe5
1 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
frankenphp.c
View File

@@ -167,15 +167,11 @@ PHPAPI void get_full_env(zval *track_vars_array) {
go_string key = full_env.r0[i * 2];
go_string val = full_env.r0[i * 2 + 1];
// create PHP strings for key and value
zend_string *key_str = zend_string_init(key.data, key.len, 0);
// create PHP string for the value
zend_string *val_str = zend_string_init(val.data, val.len, 0);
// add to the associative array
add_assoc_str(track_vars_array, ZSTR_VAL(key_str), val_str);
// release the key string
zend_string_release(key_str);
add_assoc_str_ex(track_vars_array, key.data, key.len, val_str);
}
}