php/archived-frankenphp
1
0
Fork 0
mirror of https://github.com/php/frankenphp.git synced 2026-03-24 00:52:11 +01:00
Code Issues Packages Projects Releases Wiki Activity

perf: extend table on env startup instead of letting zend_hash_copy do it (#2272)

Browse Source 
this can potentially save us a few internal calls to zend_hash_do_resize
while it loops over the source table (main_thread_env)

`8 -> 16 -> 32 -> 64 -> 128` becomes `8 -> target_size (rounded to power
of 2) 128`.
This commit is contained in:
Marc
2026-03-12 22:23:39 +07:00
committed by GitHub
parent f595cea5cd
commit 2895273476
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
frankenphp.c
View File

@@ -288,6 +288,8 @@ bool frankenphp_shutdown_dummy_request(void) {
}
void get_full_env(zval *track_vars_array) {
zend_hash_extend(Z_ARR_P(track_vars_array),
zend_hash_num_elements(main_thread_env), 0);
zend_hash_copy(Z_ARR_P(track_vars_array), main_thread_env, NULL);
}
@@ -813,6 +815,7 @@ void frankenphp_register_server_vars(zval *track_vars_array,
frankenphp_server_vars vars) {
HashTable *ht = Z_ARRVAL_P(track_vars_array);
zend_hash_extend(ht, vars.total_num_vars, 0);
zend_hash_copy(ht, main_thread_env, NULL);
// update values with variable strings
#define FRANKENPHP_REGISTER_VAR(name) \
@@ -958,9 +961,7 @@ static void frankenphp_register_variables(zval *track_vars_array) {
* $_SERVER and $_ENV should only contain values from the original
* environment, not values added though putenv
*/
zend_hash_copy(Z_ARR_P(track_vars_array), main_thread_env, NULL);
/* import CGI variables from the request context in go */
/* import environment and CGI variables from the request context in go */
go_register_server_variables(thread_index, track_vars_array);
/* Some variables are already present in SG(request_info) */