The current user and group ID are passed passed to the docker build command
and the ownership of the cloned directories are changed to them.
This gets rid of git's "dubious ownership" error.
Without this changes I got an error:
> $ make
> docker run --rm -v :/var/www/en -w /var/www -u 1000:1000 php/doc-en
> configure.php on PHP 8.2.29, libxml 2.9.14
>
> fatal: detected dubious ownership in repository at '/var/www/doc-base'
> To add an exception for this directory, call:
>
> git config --global --add safe.directory /var/www/doc-base
> doc-base/temp clean up FAILED.
> make: *** [Makefile:22: xhtml] Fehler 1
Resolves: https://github.com/php/doc-en/pull/4645
Passing "." as path does not work with docker 20.10.24:
> $ make
> docker run --rm -v .:/var/www/en -w /var/www -u 1000:1000 php/doc-en
> docker: Error response from daemon: create .: volume name is too short, names should be at least two alphanumeric characters.
> See 'docker run --help'.
> make: *** [Makefile:22: xhtml] Fehler 125
This reverts commit 6a05d92a32.
On the request of Máté to fix the build.
It might make sense to rewrite history and force push to prevent revcheck issues, but that's another debate.
* Fix return type for 5 functions: bool -> true
These functions always return true (or throw on error):
- finfo_close (fileinfo)
- ftp_set_option (ftp)
- libxml_set_external_entity_loader (libxml)
- shm_detach (shmop)
- array_multisort (standard)
* Add changelog entries for return type change bool -> true
* Fix changelog version: use 8.5.0 instead of entity hardcoded to 8.2.0
The &return.type.true; entity is hardcoded with version 8.2.0, but all
5 functions changed their return type from bool to true in PHP 8.5.
Replace the entity with manual changelog rows using the correct version.
Updates the FAQ:
- Mentions named arguments in the parameter order entry.
- Adds a note discouraging manual escaping in the addslashes entry,
recommending prepared statements and parameter binding instead.
* Document new API in ext-mongodb 2.2.0
* Apply suggestions from code review
Co-authored-by: Jeremy Mikola <jmikola@gmail.com>
---------
Co-authored-by: Jeremy Mikola <jmikola@gmail.com>
Don't include `odbc.changelog.connection-param`, not every function that
returns a connection has a connection parameter (and, in fact, neither of the
existing uses of the connection-return entity, for `odbc_connect()` and
`odbc_pconnect()`, has such a parameter).
Make it a bit more visible yet that DATE_ISO8601 is not compatible with
ISO-8601 (anyone wondering “why ‘like’?” will hopefully see the note
immediately below), and mention the standards that Atom is compatible
with (straight from RFC 4287, section 3.3; I omitted the “Date and Time
Formats” W3C note as it doesn’t seem as prominent as the others) in the
hope of encouraging more people to use it.
Initially I thought the `locale` parameter was missing from the signature. However, `grapheme_str_split()` actually accepts only 2 arguments in PHP 8.5.2 — meaning the parameter description was added to the documentation erroneously
