We actually do return bool in sismember so do the same here

This commit is contained in:
michael-grunder
2025-08-30 14:38:10 -07:00
committed by Michael Grunder
parent 38115decb9
commit 92137ffd3f
9 changed files with 26 additions and 20 deletions

View File

@@ -3197,7 +3197,7 @@ PHP_METHOD(Redis, vinfo) {
}
PHP_METHOD(Redis, vismember) {
REDIS_PROCESS_KW_CMD("VISMEMBER", redis_kv_cmd, redis_long_response);
REDIS_PROCESS_KW_CMD("VISMEMBER", redis_kv_cmd, redis_1_response);
}
PHP_METHOD(Redis, vemb) {

View File

@@ -4276,9 +4276,9 @@ class Redis {
* @param string $key The vector set to query.
* @param mixed $member The member to check for.
*
* @return Redis|int|false 1 if the member exists, 0 if it does not.
* @return Redis|bool true if the member exists, false if it does not.
*/
public function vismember(string $key, mixed $member): Redis|int|false;
public function vismember(string $key, mixed $member): Redis|bool;
/**
* Get the embeddings for a specific member

View File

@@ -1,5 +1,5 @@
/* This is a generated file, edit the .stub.php file instead.
* Stub hash: 44ceaf06991ed7aa445c0106df591416a9437a77 */
* Stub hash: 26d337d9f4984fe9e2c15c4245620494cb6ac24e */
ZEND_BEGIN_ARG_INFO_EX(arginfo_class_Redis___construct, 0, 0, 0)
ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, options, IS_ARRAY, 1, "null")
@@ -1082,7 +1082,7 @@ ZEND_END_ARG_INFO()
#define arginfo_class_Redis_vinfo arginfo_class_Redis_getWithMeta
ZEND_BEGIN_ARG_WITH_RETURN_OBJ_TYPE_MASK_EX(arginfo_class_Redis_vismember, 0, 2, Redis, MAY_BE_LONG|MAY_BE_FALSE)
ZEND_BEGIN_ARG_WITH_RETURN_OBJ_TYPE_MASK_EX(arginfo_class_Redis_vismember, 0, 2, Redis, MAY_BE_BOOL)
ZEND_ARG_TYPE_INFO(0, key, IS_STRING, 0)
ZEND_ARG_TYPE_INFO(0, member, IS_MIXED, 0)
ZEND_END_ARG_INFO()
@@ -1098,7 +1098,10 @@ ZEND_BEGIN_ARG_WITH_RETURN_OBJ_TYPE_MASK_EX(arginfo_class_Redis_vrandmember, 0,
ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, count, IS_LONG, 0, "0")
ZEND_END_ARG_INFO()
#define arginfo_class_Redis_vrem arginfo_class_Redis_vismember
ZEND_BEGIN_ARG_WITH_RETURN_OBJ_TYPE_MASK_EX(arginfo_class_Redis_vrem, 0, 2, Redis, MAY_BE_LONG|MAY_BE_FALSE)
ZEND_ARG_TYPE_INFO(0, key, IS_STRING, 0)
ZEND_ARG_TYPE_INFO(0, member, IS_MIXED, 0)
ZEND_END_ARG_INFO()
ZEND_BEGIN_ARG_WITH_RETURN_OBJ_TYPE_MASK_EX(arginfo_class_Redis_vsetattr, 0, 3, Redis, MAY_BE_LONG|MAY_BE_FALSE)
ZEND_ARG_TYPE_INFO(0, key, IS_STRING, 0)
@@ -1200,7 +1203,7 @@ ZEND_BEGIN_ARG_WITH_RETURN_OBJ_TYPE_MASK_EX(arginfo_class_Redis_zRandMember, 0,
ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, options, IS_ARRAY, 1, "null")
ZEND_END_ARG_INFO()
#define arginfo_class_Redis_zRank arginfo_class_Redis_vismember
#define arginfo_class_Redis_zRank arginfo_class_Redis_vrem
ZEND_BEGIN_ARG_WITH_RETURN_OBJ_TYPE_MASK_EX(arginfo_class_Redis_zRem, 0, 2, Redis, MAY_BE_LONG|MAY_BE_FALSE)
ZEND_ARG_TYPE_INFO(0, key, IS_MIXED, 0)
@@ -1244,7 +1247,7 @@ ZEND_BEGIN_ARG_WITH_RETURN_OBJ_TYPE_MASK_EX(arginfo_class_Redis_zRevRangeByScore
ZEND_ARG_TYPE_MASK(0, options, MAY_BE_ARRAY|MAY_BE_BOOL, "[]")
ZEND_END_ARG_INFO()
#define arginfo_class_Redis_zRevRank arginfo_class_Redis_vismember
#define arginfo_class_Redis_zRevRank arginfo_class_Redis_vrem
ZEND_BEGIN_ARG_WITH_RETURN_OBJ_TYPE_MASK_EX(arginfo_class_Redis_zScore, 0, 2, Redis, MAY_BE_DOUBLE|MAY_BE_FALSE)
ZEND_ARG_TYPE_INFO(0, key, IS_STRING, 0)

View File

@@ -3201,7 +3201,7 @@ PHP_METHOD(RedisCluster, vinfo) {
}
PHP_METHOD(RedisCluster, vismember) {
CLUSTER_PROCESS_KW_CMD("VISMEMBER", redis_kv_cmd, cluster_long_resp, 1);
CLUSTER_PROCESS_KW_CMD("VISMEMBER", redis_kv_cmd, cluster_1_resp, 1);
}
PHP_METHOD(RedisCluster, vemb) {

View File

@@ -1094,9 +1094,9 @@ class RedisCluster {
* @param string $key The vector set to query.
* @param mixed $member The member to check for.
*
* @return RedisCluster|int|false 1 if the member exists, 0 if it does not.
* @return RedisCluster|bool true if the member exists, false if it does not.
*/
public function vismember(string $key, mixed $member): RedisCluster|int|false;
public function vismember(string $key, mixed $member): RedisCluster|bool;
/**
* @see Redis::vemb

View File

@@ -1,5 +1,5 @@
/* This is a generated file, edit the .stub.php file instead.
* Stub hash: 3a4992567c20fe852dfd0351625314e82ccec30a */
* Stub hash: c8d6113b07ba9386e41ab8513190c87415676bd0 */
ZEND_BEGIN_ARG_INFO_EX(arginfo_class_RedisCluster___construct, 0, 0, 1)
ZEND_ARG_TYPE_INFO(0, name, IS_STRING, 1)
@@ -898,7 +898,7 @@ ZEND_END_ARG_INFO()
#define arginfo_class_RedisCluster_vinfo arginfo_class_RedisCluster_getWithMeta
ZEND_BEGIN_ARG_WITH_RETURN_OBJ_TYPE_MASK_EX(arginfo_class_RedisCluster_vismember, 0, 2, RedisCluster, MAY_BE_LONG|MAY_BE_FALSE)
ZEND_BEGIN_ARG_WITH_RETURN_OBJ_TYPE_MASK_EX(arginfo_class_RedisCluster_vismember, 0, 2, RedisCluster, MAY_BE_BOOL)
ZEND_ARG_TYPE_INFO(0, key, IS_STRING, 0)
ZEND_ARG_TYPE_INFO(0, member, IS_MIXED, 0)
ZEND_END_ARG_INFO()
@@ -914,7 +914,10 @@ ZEND_BEGIN_ARG_WITH_RETURN_OBJ_TYPE_MASK_EX(arginfo_class_RedisCluster_vrandmemb
ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, count, IS_LONG, 0, "0")
ZEND_END_ARG_INFO()
#define arginfo_class_RedisCluster_vrem arginfo_class_RedisCluster_vismember
ZEND_BEGIN_ARG_WITH_RETURN_OBJ_TYPE_MASK_EX(arginfo_class_RedisCluster_vrem, 0, 2, RedisCluster, MAY_BE_LONG|MAY_BE_FALSE)
ZEND_ARG_TYPE_INFO(0, key, IS_STRING, 0)
ZEND_ARG_TYPE_INFO(0, member, IS_MIXED, 0)
ZEND_END_ARG_INFO()
ZEND_BEGIN_ARG_WITH_RETURN_OBJ_TYPE_MASK_EX(arginfo_class_RedisCluster_vlinks, 0, 2, RedisCluster, MAY_BE_ARRAY|MAY_BE_FALSE)
ZEND_ARG_TYPE_INFO(0, key, IS_STRING, 0)
@@ -1104,7 +1107,7 @@ ZEND_BEGIN_ARG_WITH_RETURN_OBJ_TYPE_MASK_EX(arginfo_class_RedisCluster_zrangebys
ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, options, IS_ARRAY, 0, "[]")
ZEND_END_ARG_INFO()
#define arginfo_class_RedisCluster_zrank arginfo_class_RedisCluster_vismember
#define arginfo_class_RedisCluster_zrank arginfo_class_RedisCluster_vrem
ZEND_BEGIN_ARG_WITH_RETURN_OBJ_TYPE_MASK_EX(arginfo_class_RedisCluster_zrem, 0, 2, RedisCluster, MAY_BE_LONG|MAY_BE_FALSE)
ZEND_ARG_TYPE_INFO(0, key, IS_STRING, 0)
@@ -1129,7 +1132,7 @@ ZEND_END_ARG_INFO()
#define arginfo_class_RedisCluster_zrevrangebyscore arginfo_class_RedisCluster_zrevrange
#define arginfo_class_RedisCluster_zrevrank arginfo_class_RedisCluster_vismember
#define arginfo_class_RedisCluster_zrevrank arginfo_class_RedisCluster_vrem
ZEND_BEGIN_ARG_WITH_RETURN_OBJ_TYPE_MASK_EX(arginfo_class_RedisCluster_zscan, 0, 2, RedisCluster, MAY_BE_BOOL|MAY_BE_ARRAY)
ZEND_ARG_TYPE_INFO(0, key, IS_STRING, 0)

View File

@@ -1,5 +1,5 @@
/* This is a generated file, edit the .stub.php file instead.
* Stub hash: 3a4992567c20fe852dfd0351625314e82ccec30a */
* Stub hash: c8d6113b07ba9386e41ab8513190c87415676bd0 */
ZEND_BEGIN_ARG_INFO_EX(arginfo_class_RedisCluster___construct, 0, 0, 1)
ZEND_ARG_INFO(0, name)

View File

@@ -1,5 +1,5 @@
/* This is a generated file, edit the .stub.php file instead.
* Stub hash: 44ceaf06991ed7aa445c0106df591416a9437a77 */
* Stub hash: 26d337d9f4984fe9e2c15c4245620494cb6ac24e */
ZEND_BEGIN_ARG_INFO_EX(arginfo_class_Redis___construct, 0, 0, 0)
ZEND_ARG_INFO(0, options)

View File

@@ -7761,8 +7761,8 @@ class Redis_Test extends TestSuite {
$this->assertIsInt($this->redis->del('v'));
$this->assertEquals(1, $this->redis->vadd('v', [0.5, 1.0], 'exists'));
$this->assertEquals(1, $this->redis->vismember('v', 'exists'));
$this->assertEquals(0, $this->redis->vismember('v', 'doesnotexist'));
$this->assertEquals(true, $this->redis->vismember('v', 'exists'));
$this->assertEquals(false, $this->redis->vismember('v', 'doesnotexist'));
}
public function testVEmb() {