php-win-ext/phpredis
1
0
Fork 0
mirror of https://github.com/php-win-ext/phpredis.git synced 2026-03-24 00:52:16 +01:00
Code Issues Packages Projects Releases Wiki Activity

Refactor redis_replicaof_cmd

Browse Source 
It was the last place we were using `REDIS_SPPRINTF` in
`redis_commands.c`.
This commit is contained in:
michael-grunder
2025-08-27 16:37:08 -07:00
parent 8d369f4d62
commit 659dc763e0
1 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
redis_commands.c
View File

@@ -1295,6 +1295,7 @@ int redis_replicaof_cmd(INTERNAL_FUNCTION_PARAMETERS, RedisSock *redis_sock,
char *kw, char **cmd, int *cmd_len, short *slot,
void **ctx)
{
smart_string cmdstr = {0};
zend_string *host = NULL;
zend_long port = 6379;
@@ -1309,12 +1310,19 @@ int redis_replicaof_cmd(INTERNAL_FUNCTION_PARAMETERS, RedisSock *redis_sock,
return FAILURE;
}
redis_cmd_init_sstr(&cmdstr, 2, kw, strlen(kw));
if (ZEND_NUM_ARGS() == 2) {
*cmd_len = REDIS_SPPRINTF(cmd, kw, "Sd", host, (int)port);
redis_cmd_append_sstr_zstr(&cmdstr, host);
redis_cmd_append_sstr_long(&cmdstr, port);
} else {
*cmd_len = REDIS_SPPRINTF(cmd, kw, "ss", ZEND_STRL("NO"), ZEND_STRL("ONE"));
REDIS_CMD_APPEND_SSTR_STATIC(&cmdstr, "NO");
REDIS_CMD_APPEND_SSTR_STATIC(&cmdstr, "ONE");
}
*cmd = cmdstr.c;
*cmd_len = cmdstr.len;
return SUCCESS;
}