Prepare 2.0.13

If a `source` directory is found in the User profile (via
%USERPROFILE%\Source) the VS 2017 Command Prompt script will change to
this directory in its clean-up routines.

This fix uses the VSCMD_START_DIR variable which is provided as an
escape-hatch for this behavior, in `..\core\vsdevcmd_end.bat`.

README.md

@@ -4,7 +4,7 @@ PHP SDK is a tool kit for Windows PHP builds
 
 # License
 
-The PHP SDK itself and the SDK own tools are licensed under the BSD 2-Clause license. With the usage of the other tools, you accept the respective licenses.
+The PHP SDK itself and the SDK own tools and code are licensed under the BSD 2-Clause license. With the usage of the other tools, you accept the respective licenses.
 
 # Overview
 
@@ -32,12 +32,12 @@ All the tools included are either scripts or 32-bit binaries. They are therefore
 
 ## Other tools
 
-- `bison` 3.0.2, `re2c` 0.15.3, `lemon`
+- `bison` 3.0.4, `re2c` 1.0.2, `lemon`
 - `awk`, `gawk`, `sed`, `grep`
 - `diff`, `diff3`, `patch`
 - `md5sum`, `sha1sum`, `sha224sum`, `sha256sum`, `sha384sum`, `sha512sum`
 - `7za`, `zip`, `unzip`, `unzipsfx`
-- `wget`
+- `wget`, `pwgen`
 
 ## Optional, not included
 
@@ -60,7 +60,7 @@ It is not required to hold the source in the PHP SDK directory. It could be usef
 
 - `git clone https://github.com/OSTC/php-sdk-binary-tools.git c:\php-sdk`
 - `cd c:\php-sdk`
-- `git checkout php-sdk-2.0.0` or later
+- `git checkout php-sdk-2.0.12` or later
 - invoke `phpsdk-vc15-x64.bat`
 - `phpsdk_buildtree phpmaster`
 - `git clone https://github.com/php/php-src.git && cd php-src`, or fetch a zipball
@@ -90,6 +90,8 @@ The starter scripts can be also easy integrated with the consoles other than sta
 
 An elementary functionality to run unattended builds is included. See an example on how to setup a simple unattended build task in the doc directory.
 
+Be aware, that starter scripts always start a new shell. Scripts intended to run as a task need to be passed with `-t` argument to a starter script.
+
 # Upgrading
 
 - backup phpsdk-local.bat
@@ -102,14 +104,14 @@ If the PHP SDK is kept as a git checkout, merely what is needed instead is to gi
 
 # Extending
 
-The SDK tools are based on the KISS principle and should be kept so. Basic tools are implemented as simple batch script. The minimalistic `PHP` is available for internal SDK purposes. It can be used, if more complexity is required. If you have an idea for some useful tool or workflow, please open a ticket or PR, so it can be discussed, implemented and added to the SDK. By contributing an implementation, you should also accept the SDK license.
+The SDK tools are based on the KISS principle and should be kept so. Basic tools are implemented as simple batch script. The minimalistic `PHP` is available for internal SDK purposes. It can be used, if more complexity is required. A suitable PHP binary is bound with the PHP SDK. If you have an idea for some useful tool or workflow, please open a ticket or PR, so it can be discussed, implemented and added to the SDK. By contributing an implementation, you should also accept the SDK license.
 
 # Pitfalls
 
 - SDK or PHP sources put into paths including spaces might cause issue.
 - SDK or PHP sources put into too long paths, will cause an issue.
-- If Cygwin is installed, it might cause issues. If it's unavoidable, to have Cygwin on the same machine, ensure SDK preceeds it on the PATH.
-- When fetching from git, git `core.autocrlf` configuration directive set to `false` is recommended.
+- If Cygwin, MSYS2 or MinGW flavors are exposed in global PATH, it might cause issues. If it's unavoidable, ensure SDK preceeds it on the PATH.
+- When fetching the binary SDK from git, git `core.autocrlf` configuration directive set to `false` is recommended.
 - Tools, based on MSYS2, only accept paths with forward slashes.
 - Both Visual C++ toolset and the Windows SDK components have to be installed for the PHP SDK to work properly. 
 - The VC++ toolset is still requried, even if another compiler, fe. clang, is intended to be used.

VERSION

@@ -1 +1 @@
-2.0.10
+2.0.13

bin/phpsdk_deps.php

@@ -187,7 +187,7 @@ function usage(int $code = -1)
 	echo "PHP SDK dependency handling tool.", PHP_EOL;
 	echo "Usage: ", PHP_EOL, PHP_EOL;
 	echo "Configuration:", PHP_EOL;
-	echo "  -b --branch    Branch name, eg. 7.0, 7.1, etc. If omited, CWD is used to guess.", PHP_EOL;
+	echo "  -b --branch    Branch name, eg. 7.0, 7.1, etc. If omited, several guess methods apply.", PHP_EOL;
 	echo "  -a --arch      Architecture, x86 or x64. If omited, cl.exe is used to guess.", PHP_EOL;
 	echo "  -t --crt       CRT, marked by the corresponding VC++ version, eg. vc11, vc14, etc.", PHP_EOL;
 	echo "  -s --stability One of stable or staging.", PHP_EOL, PHP_EOL;

bin/phpsdk_dllmap.php

@@ -6,7 +6,7 @@
 	- create mappings between dll filename and zip filename
 
 	Usage:
-	php dllmap.php path0 [ path1 ... ] > dllmapping.json
+	php dllmap.php [--pretty] path0 [ path1 ... ] > dllmapping.json
 */
 
 
@@ -20,8 +20,25 @@
 	"C:\\tmp\\libs",
 );*/
 
+$sopt = "p";
+$lopt = array(
+	"pretty",
+);
+
+$flags = 0;
+$opt = getopt($sopt, $lopt);
+foreach ($opt as $name => $val) {
+	switch ($name) {
+			case "p":
+			case "pretty":
+				$flags = JSON_PRETTY_PRINT;
+				break;
+	}
+}
+
+
 $dirs = array();
-foreach (array_slice($_SERVER["argv"], 1) as $item) {
+foreach (array_slice($_SERVER["argv"], (0 == $flags ? 1 : 2)) as $item) {
 	if (file_exists($item) && is_dir($item)) {
 		$dirs[] = $item;
 	}
@@ -32,26 +49,7 @@ if (empty($dirs)) {
 	die;
 }
 
-
-$out = array(
-	"vc9" => array(
-		"x86" => array(),
-		"x64" => array(),
-	),
-	"vc11" => array(
-		"x86" => array(),
-		"x64" => array(),
-	),
-	"vc12" => array(
-		"x86" => array(),
-		"x64" => array(),
-	),
-	"vc14" => array(
-		"x86" => array(),
-		"x64" => array(),
-	),
-);
-
+$out = array();
 
 foreach ($dirs as $path) {
 	$dir = new DirectoryIterator($path);
@@ -74,6 +72,13 @@ foreach ($dirs as $path) {
 		$crt = $m[1];
 		$arch = $m[2];
 
+		if (!isset($out[$crt])) {
+			$out[$crt] = array();
+		}
+		if (!isset($out[$crt][$arch])) {
+			$out[$crt][$arch] = array();
+		}
+
 		$zip = new ZipArchive();
 
 		$zip->open($pathname);
@@ -100,7 +105,7 @@ foreach ($dirs as $path) {
 	}
 }
 
-echo json_encode($out);
+echo json_encode($out, $flags);
 
 /*
  * Local variables:

bin/phpsdk_setshell.bat

@@ -98,6 +98,21 @@ set TMPKEY=
 
 if 15 gtr %PHP_SDK_VC_NUM% (
 	rem get sdk dir
+	rem if 10.0 is available, it's ok
+	if /i "%PHP_SDK_OS_ARCH%"=="x64" (
+		set TMPKEY=HKEY_LOCAL_MACHINE\SOFTWARE\Wow6432Node\Microsoft\Microsoft SDKs\Windows\v10.0
+	) else (
+		set TMPKEY=HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Microsoft SDKs\Windows\v10.0
+	)
+	for /f "tokens=2*" %%a in ('reg query "!TMPKEY!" /v InstallationFolder') do (
+		for /f "tokens=2*" %%c in ('reg query "!TMPKEY!" /v ProductVersion') do (
+			if exist "%%bInclude\%%d.0\um\Windows.h" (
+				goto got_sdk
+			)
+		)
+	)
+
+	rem Otherwise 8.1 should be available anyway
 	if /i "%PHP_SDK_OS_ARCH%"=="x64" (
 		set TMPKEY=HKEY_LOCAL_MACHINE\SOFTWARE\Wow6432Node\Microsoft\Microsoft SDKs\Windows\v8.1
 	) else (
@@ -105,13 +120,13 @@ if 15 gtr %PHP_SDK_VC_NUM% (
 	)
 	for /f "tokens=2*" %%a in ('reg query "!TMPKEY!" /v InstallationFolder') do (
 		if exist "%%b\Include\um\Windows.h" (
-			set PHP_SDK_WIN_SDK_DIR=%%b
+			goto got_sdk
 		)
 	)
-	if not defined PHP_SDK_WIN_SDK_DIR (
-		echo Windows SDK not found.
-		goto out_error;
-	)
+
+	echo Windows SDK not found.
+	goto out_error;
+:got_sdk
 	set TMPKEY=
 )
 

lib/php/libsdk/SDK/Build/Dependency/Manager.php

@@ -2,7 +2,7 @@
 
 namespace SDK\Build\Dependency;
 
-use SDK\{Config, Cache, Exception, FileOps};
+use SDK\{Config, Cache, Exception, FileOps, Lock};
 
 class Manager
 {
@@ -39,7 +39,7 @@ class Manager
 
 	public function updatesAvailable() : bool
 	{/*{{{*/
-		return $this->series->updatesAvailable();
+		return $this->series->updatesAvailable() || !file_exists(Config::getDepsLocalPath());
 	}/*}}}*/
 
 	/* FIXME implement rollback */
@@ -50,6 +50,15 @@ class Manager
 				$msg .= "No updates are available";
 				return;
 			}
+
+			$lock = new Lock(Config::getDepsLocalPath());
+			if (!$lock->locked()) {
+				$msg .= "Dependencies was updated by another process.";
+				echo "Another process is updating same dependency path. I'm just going to wait for it to finish and then exit.", PHP_EOL;
+				$lock->exclusive(true);
+				unset($lock);
+				return;
+			}
 		}
 
 		$series_data = $this->series->getData();
@@ -86,10 +95,16 @@ class Manager
 
 				/* This is fine, it's gonna be on the same drive. */
 				if (!$this->mv($this->path, $new_path)) {
+					if (!$force) {
+						unset($lock);
+					}
 					throw new Exception("Unable to rename '{$this->path}' to '$new_path'");
 				}
 			} else {
 				if (!$this->rm($this->path)) {
+					if (!$force) {
+						unset($lock);
+					}
 					throw new Exception("Unable to remove the current dependency dir at '{$this->path}'");
 				}
 			}
@@ -97,6 +112,9 @@ class Manager
 			$up = dirname($this->path);
 			if (!file_exists($up)) {
 				if (!$this->md($up)) {
+					if (!$force) {
+						unset($lock);
+					}
 					throw new Exception("Unable to create '{$this->path}'");
 				}
 			}
@@ -118,6 +136,10 @@ class Manager
 		} else {
 			$msg .= "No backup was created.";
 		}
+
+		if (!$force) {
+			unset($lock);
+		}
 	}/*}}}*/
 }
 

lib/php/libsdk/SDK/Cache.php

@@ -55,7 +55,26 @@ class Cache
 	{/*{{{*/
 		$p = $this->getCacheablePath($path, $relative);
 
-		if (strlen($content) !== file_put_contents($p, $content)) {
+		$to_write = strlen($content);
+		$wrote = 0;
+
+		$fd = fopen($p, "wb");
+
+		flock($fd, LOCK_EX);
+
+		do {
+			$got = fwrite($fd, substr($content, $wrote));
+			if (false == $got) {
+				break;
+			}
+			$wrote += $got;
+		} while ($wrote < $to_write);
+
+		flock($fd, LOCK_UN);
+
+		fclose($fd);
+
+		if ($to_write !== $wrote) {
 			throw new Exception("Couldn't cache '$p'");
 		}
 	}/*}}}*/

lib/php/libsdk/SDK/Config.php

@@ -55,19 +55,18 @@ class Config
 		if (NULL === self::$currentArchName) {
 			/* XXX this might be not true for other compilers! */
 			passthru("where cl.exe >nul", $status);
-			if ($status) {
-				throw new Exception("Couldn't find cl.exe.");
-			}
-
-			exec("cl.exe /? 2>&1", $a, $status);
 			if ($status) {
 				throw new Exception("Couldn't execute cl.exe.");
 			}
 
-			if (preg_match(",x64,", $a[0])) {
+			exec("cl.exe /? 2>&1", $out);
+
+			if (preg_match(",x64,", $out[0])) {
 				self::setCurrentArchName("x64");
-			} else {
+			} elseif (preg_match(",x86,", $out[0])) {
 				self::setCurrentArchName("x86");
+			} else {
+				throw new Exception("Couldn't determine Arch.");
 			}
 		}
 
@@ -172,10 +171,25 @@ class Config
 	public static function guessCurrentBranchName() : ?string
 	{/*{{{*/
 		$branch = NULL;
+		$found = false;
 
-		/* Try to figure out the branch. For now it only works if CWD is in php-src. */
+		/* Try to figure out the branch. The worky scenarios are
+			- CWD is in php-src 
+			- phpize is on the path
+			FIXME for the dev package, there should be a php-config utility
+		 */
 		$fl = "main/php_version.h";
-		if (file_exists($fl)) {
+		$found = file_exists($fl);
+
+		if (!$found) {
+			exec("where phpize", $out, $status);
+			if (!$status) {
+				$fl = dirname($out[0]) . DIRECTORY_SEPARATOR . "include" . DIRECTORY_SEPARATOR . $fl;
+				$found = file_exists($fl);
+			}
+		}
+
+		if ($found) {
 			$s = file_get_contents($fl);
 			$major = $minor = NULL;
 

lib/php/libsdk/SDK/FileOps.php

@@ -117,7 +117,7 @@ trait FileOps
 	}/*}}}*/
 
 	protected function download(string $url, string $dest = NULL) : ?string
-	{
+	{/*{{{*/
 		$fd = NULL;
 		$ch = curl_init($url);
 
@@ -134,7 +134,7 @@ trait FileOps
 
 		$ret = curl_exec($ch);
 		if (false === $ret) {
-			$err = curl_error();
+			$err = curl_error($ch);
 			curl_close($ch);
 			if ($dest) {
 				fclose($fd);
@@ -150,7 +150,7 @@ trait FileOps
 		}
 
 		return $ret;
-	}
+	}/*}}}*/
 }
 
 /*

lib/php/libsdk/SDK/Lock.php

@@ -0,0 +1,107 @@
+<?php
+
+namespace SDK;
+
+use SDK\{Config, Exception};
+
+class Lock
+{
+	protected $fd;
+	protected $fn;
+	protected $locked = false;
+	protected $wouldBlock = false;
+	protected $shared = false;
+
+	public function __construct(string $tag, bool $auto = true, bool $autoShared = false)
+	{/*{{{*/
+		$hash = hash("sha256", $tag);
+		$this->fn = Config::getTmpDir() . DIRECTORY_SEPARATOR . $hash . ".lock";
+
+		if ($auto) {
+			if ($autoShared) {
+				$this->shared();
+			} else {
+				$this->exclusive();
+			}
+		}
+	}/*}}}*/
+
+	public function __destruct()
+	{/*{{{*/
+		$this->unlock();
+		/* We don't really know no one else waits on the same lock yet.*/
+		/*if (file_exists($this->fn) && !$this->shared) {
+			@unlink($this->fn);
+		}*/
+	}/*}}}*/
+
+	public function shared(bool $block = false) : bool
+	{/*{{{*/
+		$flags = LOCK_SH;
+		if (!$block) {
+			$flags |= LOCK_NB;
+		}
+
+		return $this->doLock($flags);
+	}/*}}}*/
+
+	public function exclusive(bool $block = false) : bool
+	{/*{{{*/
+		$flags = LOCK_EX;
+		if (!$block) {
+			$flags |= LOCK_NB;
+		}
+
+		return $this->doLock($flags);
+	}/*}}}*/
+
+	protected function doLock(int $flags = LOCK_EX) : bool
+	{/*{{{*/
+		if ($this->locked) {
+			/* Or throw an exception, as we don't know which lock type the outta world expected. */
+			return true;
+		}
+
+		$this->shared = $flags & LOCK_SH;
+		if ($this->shared) {
+			$this->fd = fopen($this->fn, "rb");
+		} else {
+			$this->fd = fopen($this->fn, "wb");
+		}
+		$this->locked = flock($this->fd, $flags, $this->wouldBlock);	
+		return $this->locked;
+	}/*}}}*/
+
+	public function unlock() : bool
+	{/*{{{*/
+		if (!$this->locked) {
+			return true;
+		}
+
+		$this->doLock(LOCK_UN);
+
+		fclose($this->fd);
+		$this->fd = NULL;
+
+		return $this->locked;
+	}/*}}}*/
+
+	public function locked() : bool
+	{/*{{{*/
+		return $this->locked;
+	}/*}}}*/
+
+	public function wouldBlock() : bool
+	{/*{{{*/
+		return 1 === $this->wouldBlock;
+	}/*}}}*/
+}
+
+/*
+ * Local variables:
+ * tab-width: 4
+ * c-basic-offset: 4
+ * End:
+ * vim600: sw=4 ts=4 fdm=marker
+ * vim<600: sw=4 ts=4
+ */

phpsdk-starter.bat

@@ -2,6 +2,10 @@
 
 setlocal enableextensions enabledelayedexpansion
 
+rem make sure we end up where we started (for VS2017)
+set "VSCMD_START_DIR=%CD%"
+set "__VSCMD_ARG_NO_LOGO=yes"
+
 rem this will be eventually overridden by phpsdk_setvars, but nothing wrong to use the same name here
 set PHP_SDK_ROOT_PATH=%~dp0
 set PHP_SDK_ROOT_PATH=%PHP_SDK_ROOT_PATH:~0,-1%
@@ -31,7 +35,7 @@ set ARCH=%ARCH: =%
 set PHP_SDK_RUN_FROM_ROOT=1
 
 
-title PHP SDK %CRT% %ARCH%
+title PHP SDK %CRT% %ARCH%
 
 call %PHP_SDK_ROOT_PATH%\bin\phpsdk_setshell.bat %CRT% %ARCH%
 
@@ -62,9 +66,9 @@ if "%TASK%" neq "" (
 )
 
 if exist "%PHP_SDK_ROOT_PATH%\phpsdk-local.bat" (
-	cmd /k "!PHP_SDK_VC_SHELL_CMD! && %PHP_SDK_ROOT_PATH%\bin\phpsdk_setvars.bat && %PHP_SDK_ROOT_PATH%\bin\phpsdk_dumpenv.bat && %PHP_SDK_ROOT_PATH%\phpsdk-local.bat && echo. && set prompt=$P$_$+$$$S"
+	cmd /k "!PHP_SDK_VC_SHELL_CMD! && set __VSCMD_ARG_NO_LOGO=&& set VSCMD_START_DIR=&& %PHP_SDK_ROOT_PATH%\bin\phpsdk_setvars.bat && %PHP_SDK_ROOT_PATH%\bin\phpsdk_dumpenv.bat && %PHP_SDK_ROOT_PATH%\phpsdk-local.bat && echo. && set prompt=$P$_$+$$$S"
 ) else (
-	cmd /k "!PHP_SDK_VC_SHELL_CMD! && %PHP_SDK_ROOT_PATH%\bin\phpsdk_setvars.bat && %PHP_SDK_ROOT_PATH%\bin\phpsdk_dumpenv.bat && set prompt=$P$_$+$$$S"
+	cmd /k "!PHP_SDK_VC_SHELL_CMD! && set __VSCMD_ARG_NO_LOGO=&& set VSCMD_START_DIR=&& %PHP_SDK_ROOT_PATH%\bin\phpsdk_setvars.bat && %PHP_SDK_ROOT_PATH%\bin\phpsdk_dumpenv.bat && set prompt=$P$_$+$$$S"
 )
 
 exit /b !ERRORLEVEL!