php-win-ext/php-memcached
1
0
Fork 0
mirror of https://github.com/php-win-ext/php-memcached.git synced 2026-03-24 00:52:18 +01:00
Code Issues Packages Projects Releases Wiki Activity

Cannot reset OPT_PREFIX_KEY #293 (#294)

Browse Source 
- ZSTR_VAL(str) == 0 should be ZSTR_LEN(str) == 0
- add reset_keyprefix.phpt to package.xml
This commit is contained in:
Arjen
2017-01-20 13:20:42 +01:00
committed by Aaron Stone
parent dd02191686
commit 7f6c333032
3 changed files with 40 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
package.xml
View File

@@ -164,6 +164,7 @@ Tests
<file role='test' name='session_regenerate.phpt'/>
<file role='test' name='stats.phpt'/>
<file role='test' name='default_behavior.phpt'/>
<file role='test' name='reset_keyprefix.phpt'/>
</dir>
</dir>
</contents>

2
php_memcached.c
View File

@@ -2867,7 +2867,7 @@ int php_memc_set_option(php_memc_object_t *intern, long option, zval *value)
char tmp[MEMCACHED_PREFIX_KEY_MAX_SIZE - 1];
#endif
str = zval_get_string(value);
if (ZSTR_VAL(str) == 0) {
if (ZSTR_LEN(str) == 0) {
key = NULL;
} else {
/*

38
tests/reset_keyprefix.phpt Normal file
View File

@@ -0,0 +1,38 @@
--TEST--
Cannot reset OPT_PREFIX_KEY #293
--SKIPIF--
<?php include "skipif.inc";?>
--FILE--
<?php
include dirname (__FILE__) . '/config.inc';
$m = memc_get_instance ();
$m->set('key1', 'abc');
var_dump($m->get('key1'));
$m->setOption(Memcached::OPT_PREFIX_KEY, 'prefix');
var_dump($m->get('key1'));
$m->setOption(Memcached::OPT_PREFIX_KEY, false);
var_dump($m->get('key1'));
$m->setOption(Memcached::OPT_PREFIX_KEY, 'prefix');
var_dump($m->get('key1'));
$m->setOption(Memcached::OPT_PREFIX_KEY, '');
var_dump($m->get('key1'));
$m->setOption(Memcached::OPT_PREFIX_KEY, 'prefix');
var_dump($m->get('key1'));
$m->setOption(Memcached::OPT_PREFIX_KEY, null);
var_dump($m->get('key1'));
--EXPECTF--
string(3) "abc"
bool(false)
string(3) "abc"
bool(false)
string(3) "abc"
bool(false)
string(3) "abc"