Add GitHub Actions build (#492)

travis-ci.org builds have ceased, so this patch adds a GitHub Actions workflow to build and test the extension, as well as a Dependabot configuration file to keep the referenced actions up to date. I've opted to slightly simplify the workflow compared to the Travis build script. For one, I have not included libmemcached protocol support, as most distros do not supply a libmemcached compiled with server protocol support, and previous discussion suggests its usefulness in the context of this extension may be limited.[1] I've also opted to remove multiversion libmemcached testing in favor of using the system libmemcached, as the referenced other versions seem to be old enough for this to hopefully not be a problem. These could conceivably be reintroduced if needed. --- [1] https://github.com/php-memcached-dev/php-memcached/issues/418#issuecomment-449587972
2026-03-24 00:52:18 +01:00 · 2021-11-08 18:18:14 +01:00
parent 9cd4a01d99
commit 60a8f9f881
4 changed files with 90 additions and 309 deletions
--- a/.github/dependabot.yml
+++ b/.github/dependabot.yml
@@ -0,0 +1,6 @@
+version: 2
+updates:
+  - package-ecosystem: "github-actions"
+    directory: "/"
+    schedule:
+      interval: "daily"
--- a/.github/workflows/build-and-test.yml
+++ b/.github/workflows/build-and-test.yml
@@ -0,0 +1,84 @@
+on: [push, pull_request]
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    continue-on-error: ${{ matrix.experimental }}
+    strategy:
+      fail-fast: false
+      matrix:
+        php: ['7.0', '7.1', '7.2', '7.3', '7.4', '8.0']
+        experimental: [false]
+        include:
+          - php: '8.1'
+            experimental: true
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v2
+        with:
+          submodules: true
+      - name: Install PHP ${{ matrix.php }}
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: ${{ matrix.php }}
+          extensions: none, json, igbinary, msgpack
+      - name: Install dependencies
+        run: |
+          sudo apt-get update
+          sudo apt-get install libmemcached-dev memcached libsasl2-dev sasl2-bin zlib1g-dev
+      - name: Start memcached daemons
+        run: |
+          export SASL_CONF_PATH="/tmp/sasl2"
+          mkdir "${SASL_CONF_PATH}"
+          export MEMCACHED_SASL_PWDB="${SASL_CONF_PATH}/sasldb2"
+
+          # Create configuration
+          cat<<EOF > "${SASL_CONF_PATH}/memcached.conf"
+          mech_list: PLAIN
+          plainlog_level: 5
+          sasldb_path: ${MEMCACHED_SASL_PWDB}
+          EOF
+
+          echo "test" | /usr/sbin/saslpasswd2 -c memcached -a memcached -f "${MEMCACHED_SASL_PWDB}"
+
+          # Run normal memcached
+          memcached -d -p 11211
+
+          # Run memcached on port 11212 with SASL support
+          memcached -S -d -p 11212
+      - name: Build extension
+        run: |
+          phpize
+          ./configure \
+            --enable-memcached-protocol=no \
+            --enable-memcached-sasl \
+            --enable-memcached-json \
+            --enable-memcached-msgpack \
+            --enable-memcached-igbinary
+          make
+          sudo make install
+      - name: Create test configuration
+        run: |
+          cat<<EOF > tests/config.inc.local
+          <?php
+            define ("MEMC_SERVER_HOST", "127.0.0.1");
+            define ("MEMC_SERVER_PORT", 11211);
+
+            define ("MEMC_SASL_SERVER_HOST", "127.0.0.1");
+            define ("MEMC_SASL_SERVER_PORT", 11212);
+              
+            define ('MEMC_SASL_USER', 'memcached');
+            define ('MEMC_SASL_PASS', 'test');
+          EOF
+      - name: Run tests
+        run: |
+          export NO_INTERACTION=1
+          export REPORT_EXIT_STATUS=1
+          export TEST_PHP_EXECUTABLE=$(which php)
+
+          # We have one xfail test, we run it separately
+          php run-tests.php --show-diff -d extension=modules/memcached.so ./tests/expire.phpt
+          rm ./tests/expire.phpt
+
+          # Run normal tests
+          php run-tests.php --show-diff -d extension=modules/memcached.so ./tests/*.phpt
--- a/.travis.yml
+++ b/.travis.yml
@@ -1,39 +0,0 @@
-dist: xenial
-
-language: php
-php:
-    - nightly
-    - 8.0
-    - 7.4
-    - 7.3
-    - 7.2
-    - 7.1
-    - 7.0
-
-matrix:
-    fast_finish: true
-    allow_failures:
-        - php: nightly
-
-env:
-    - LIBMEMCACHED_VERSION=1.0.18 # Debian Jessie / Ubuntu Xenial
-    - LIBMEMCACHED_VERSION=1.0.16 # RHEL / CentOS 7
-    - LIBMEMCACHED_VERSION=1.0.8  # Debian Wheezy / Ubuntu Trusty
-
-addons:
-    apt:
-        packages:
-            - sasl2-bin
-            - libsasl2-dev
-            - libevent-dev
-
-before_script:
-    - sudo apt-get purge -qq '^memcached*' '^libmemcached*'
-    - ./.travis/travis.sh before_script $LIBMEMCACHED_VERSION
-
-script:
-    - ./.travis/travis.sh script $LIBMEMCACHED_VERSION
-
-cache:
-    directories:
-    - $HOME/cache
--- a/.travis/travis.sh
+++ b/.travis/travis.sh
@@ -1,270 +0,0 @@
-#!/bin/bash
-
-function version_compare() {
-    DPKG=`which dpkg`
-
-    if [ "x$DPKG" = "x" ]; then
-        echo "dpkg not found, cannot compare versions"
-        exit 1
-    fi
-
-    $DPKG --compare-versions "$1" "$2" "$3"
-    return $?
-}
-
-function check_protocol_support() {
-    version_compare "$LIBMEMCACHED_VERSION" gt 1.0.15
-    if [ $? = 0 ]; then
-        ENABLE_PROTOOCOL=yes
-    else
-        ENABLE_PROTOOCOL=no
-    fi
-}
-
-function check_sasl_support() {
-    version_compare "$LIBMEMCACHED_VERSION" gt 1.0.15
-    if [ $? = 0 ]; then
-        ENABLE_SASL=yes
-    else
-        ENABLE_SASL=no
-    fi
-}
-
-function validate_package_xml() {
-    retval=0
-    for file in tests/*.phpt; do
-        grep $(basename $file) package.xml >/dev/null
-        if [ $? != 0 ]; then
-            echo "Missing $file from package.xml"
-            retval=1;
-        fi
-    done
-    return $retval
-}
-
-function install_libmemcached() {
-
-    if test -d "${LIBMEMCACHED_PREFIX}"
-    then
-        echo "Using cached libmemcached: ${LIBMEMCACHED_PREFIX}"
-        return
-    fi
-
-    wget "https://launchpad.net/libmemcached/1.0/${LIBMEMCACHED_VERSION}/+download/libmemcached-${LIBMEMCACHED_VERSION}.tar.gz" -O libmemcached-${LIBMEMCACHED_VERSION}.tar.gz
-
-    tar xvfz libmemcached-${LIBMEMCACHED_VERSION}.tar.gz
-    pushd "libmemcached-${LIBMEMCACHED_VERSION}"
-
-        local protocol_flag=""
-        if test "x$ENABLE_PROTOOCOL" = "xyes"; then
-            protocol_flag="--enable-libmemcachedprotocol"
-        fi
-
-        ./configure --prefix="$LIBMEMCACHED_PREFIX" $protocol_flag LDFLAGS="-lpthread"
-        make
-        make install
-    popd
-}
-
-function install_igbinary() {
-    git clone https://github.com/igbinary/igbinary.git
-    pushd igbinary
-        phpize
-        ./configure
-        make
-        make install
-    popd
-}
-
-function install_msgpack() {
-    git clone https://github.com/msgpack/msgpack-php.git
-    pushd msgpack-php
-        phpize
-        ./configure
-        make
-        make install
-    popd
-}
-
-function install_memcached() {
-    local prefix="${HOME}/cache/memcached-sasl-${MEMCACHED_VERSION}"
-
-    if test -d "$prefix"
-    then
-        echo "Using cached memcached: ${prefix}"
-        return
-    fi
-
-    wget http://www.memcached.org/files/memcached-${MEMCACHED_VERSION}.tar.gz -O memcached-${MEMCACHED_VERSION}.tar.gz
-    tar xfz memcached-${MEMCACHED_VERSION}.tar.gz
-
-    pushd memcached-${MEMCACHED_VERSION}
-        ./configure --enable-sasl --enable-sasl-pwdb --prefix="${prefix}"
-        make
-        make install
-    popd
-}
-
-function run_memcached() {
-    local prefix="${HOME}/cache/memcached-sasl-${MEMCACHED_VERSION}"
-
-    export SASL_CONF_PATH="/tmp/sasl2"
-
-    if test -d "${SASL_CONF_PATH}"
-    then
-        rm -rf "${SASL_CONF_PATH}"
-    fi
-
-    mkdir "${SASL_CONF_PATH}"
-    export MEMCACHED_SASL_PWDB="${SASL_CONF_PATH}/sasldb2"
-
-    # Create configuration
-    cat<<EOF > "${SASL_CONF_PATH}/memcached.conf"
-mech_list: PLAIN
-plainlog_level: 5
-sasldb_path: ${MEMCACHED_SASL_PWDB}
-EOF
-
-    echo "test" | /usr/sbin/saslpasswd2 -c memcached -a memcached -f "${MEMCACHED_SASL_PWDB}"
-
-    # Run normal memcached
-    "${prefix}/bin/memcached" -d -p 11211
-
-    # Run memcached on port 11212 with SASL support
-    "${prefix}/bin/memcached" -S -d -p 11212
-}
-
-function build_php_memcached() {
-    pear package
-    mkdir "$PHP_MEMCACHED_BUILD_DIR"
-    tar xfz "memcached-${PHP_MEMCACHED_VERSION}.tgz" -C "$PHP_MEMCACHED_BUILD_DIR"
-    pushd "${PHP_MEMCACHED_BUILD_DIR}/memcached-${PHP_MEMCACHED_VERSION}"
-        phpize
-
-        local protocol_flag=""
-        if test "x$ENABLE_PROTOCOL" = "xyes"; then
-            protocol_flag="--enable-memcached-protocol"
-        fi
-
-        local sasl_flag="--disable-memcached-sasl"
-        if test "x$ENABLE_SASL" = "xyes"; then
-            sasl_flag="--enable-memcached-sasl"
-        fi
-
-        # ./configure --with-libmemcached-dir="$LIBMEMCACHED_PREFIX" $protocol_flag $sasl_flag 
-        ./configure --with-libmemcached-dir="$LIBMEMCACHED_PREFIX" $protocol_flag $sasl_flag --enable-memcached-json --enable-memcached-msgpack --enable-memcached-igbinary
-        make
-        make install
-    popd
-}
-
-function create_memcached_test_configuration() {
-cat<<EOF > "${PHP_MEMCACHED_BUILD_DIR}/memcached-${PHP_MEMCACHED_VERSION}/tests/config.inc.local"
-<?php
-	define ("MEMC_SERVER_HOST", "127.0.0.1");
-	define ("MEMC_SERVER_PORT", 11211);
-
-	define ("MEMC_SASL_SERVER_HOST", "127.0.0.1");
-	define ("MEMC_SASL_SERVER_PORT", 11212);
-    
-	define ('MEMC_SASL_USER', 'memcached');
-	define ('MEMC_SASL_PASS', 'test');
-EOF
-}
-
-function run_memcached_tests() {
-    export NO_INTERACTION=1
-    export REPORT_EXIT_STATUS=1
-    export TEST_PHP_EXECUTABLE=$(which php)
-
-    pushd "${PHP_MEMCACHED_BUILD_DIR}/memcached-${PHP_MEMCACHED_VERSION}"
-        # We have one xfail test, we run it separately
-        php run-tests.php -d extension=memcached.so -n ./tests/expire.phpt
-        rm ./tests/expire.phpt
-
-        # Run normal tests
-        php run-tests.php --show-diff -d extension=modules/memcached.so -d extension=msgpack.so -d extension=igbinary.so -n ./tests/*.phpt
-        retval=$?
-    popd
-    return $retval;
-}
-
-# Command line arguments
-ACTION=$1
-LIBMEMCACHED_VERSION=$2
-MEMCACHED_VERSION="1.4.25"
-
-if test "x$ACTION" = "x"; then
-    echo "Usage: $0 <action> <libmemcached version>"
-    exit 1
-fi
-
-if test "x$LIBMEMCACHED_VERSION" = "x"; then
-    echo "Usage: $0 <action> <libmemcached version>"
-    exit 1
-fi
-
-if test "x$3" != "x"; then
-    MEMCACHED_VERSION=$3
-fi
-
-# the extension version
-PHP_MEMCACHED_VERSION=$(php -r '$sxe = simplexml_load_file ("package.xml"); echo (string) $sxe->version->release;')
-
-# Libmemcached install dir
-LIBMEMCACHED_PREFIX="${HOME}/cache/libmemcached-${LIBMEMCACHED_VERSION}"
-
-# Where to do the build
-PHP_MEMCACHED_BUILD_DIR="/tmp/php-memcached-build"
-
-# Check whether to enable building with protoocol and sasl support
-check_protocol_support
-check_sasl_support
-
-echo "Enable protocol: $ENABLE_PROTOOCOL"
-echo "Enable sasl: $ENABLE_SASL"
-
-set -e
-
-case $ACTION in
-    before_script)
-        # validate the package.xml
-        validate_package_xml || exit 1
-
-        # Install libmemcached version
-        install_libmemcached
-
-        # Install igbinary extension
-        install_igbinary
-
-        # Install msgpack extension
-        install_msgpack
-
-        install_memcached
-        run_memcached
-    ;;
-
-    script)
-        # Build the extension
-        build_php_memcached
-
-        # Create configuration
-        if test "x$ENABLE_SASL" = "xyes"; then
-            create_memcached_test_configuration
-        fi
-
-        # Run tests
-        set +e
-        run_memcached_tests || exit 1
-    ;;
-
-    *)
-        echo "Unknown action. Valid actions are: before_script and script"
-        exit 1
-    ;;
-esac
-
-
-
-
-