doctrine/archived-orm
1
0
Fork 0
mirror of https://github.com/doctrine/orm.git synced 2026-03-23 22:42:18 +01:00
Code Issues 5.3k Packages Projects Releases 100 Wiki Activity

[PR #8384] [GH-6394] Bugfix: IdentifierFlattener support for association non-object values. #10959

New Issue
Open
opened 2026-01-22 16:09:13 +01:00 by admin · 0 comments
admin commented 2026-01-22 16:09:13 +01:00
Owner
Copy Link

Original Pull Request: https://github.com/doctrine/orm/pull/8384

State: closed
Merged: Yes

Fixes #6394 Fixes #6393

BasicEntityPersister::update passes the wrong representation of identifiers to assignDefaultVersionValue. Instead of grabbing the values from UnitOfWork::getEntityIdentifier the method ClassMetadataInfo::getIdentifierValues must be used as in all other places where the identify flattener is ultimately used.

The difference is that UnitOfWork identifiers contain the scalar values representing an association identifier, but ClassMetadataInfo representation returns the actual entity object.

/cc @goetas

**Original Pull Request:** https://github.com/doctrine/orm/pull/8384 **State:** closed **Merged:** Yes --- Fixes #6394 Fixes #6393 `BasicEntityPersister::update` passes the wrong representation of identifiers to `assignDefaultVersionValue`. Instead of grabbing the values from `UnitOfWork::getEntityIdentifier` the method `ClassMetadataInfo::getIdentifierValues` must be used as in all other places where the identify flattener is ultimately used. The difference is that `UnitOfWork` identifiers contain the scalar values representing an association identifier, but `ClassMetadataInfo` representation returns the actual entity object. /cc @goetas
admin added the pull-request label 2026-01-22 16:09:13 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
BC Break
Bug
Can't Fix
Deprecation
Documentation
DQL
Duplicate
Failing Test
Hacktoberfest
Improvement
Improvement
Incomplete
Invalid
Missing Tests
New Feature
PR Created
pull-request
Mirrored from GitHub Pull Request
 Question
Regression
Status: Waiting feedback
Waiting feedback
WIP
Won't Fix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#10959
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?