Changelog for v2.1.1 (#54)

Co-authored-by: Marc DAVID <marc@Mac.local>

.travis.yml

@@ -26,9 +26,17 @@ matrix:
     - php: '7.1'
     - php: '7.2'
     - php: '7.3'
+    - php: '7.4'
+
+    # Enable code coverage with the previous supported PHP version
+    - php: '7.3'
+      env:
+        - SYMFONY_VERSION=3.4.*
+        - COVERALLS_ENABLED="true"
+        - PHPUNIT_FLAGS="-v --coverage-text --coverage-clover var/build/clover.xml"
 
     # Enable code coverage with the latest supported PHP version
-    - php: '7.3'
+    - php: '7.4'
       env:
         - SYMFONY_VERSION=3.4.*
         - COVERALLS_ENABLED="true"
@@ -59,9 +67,6 @@ matrix:
         - SYMFONY_VERSION=5.0.*
 
     # Test unsupported versions of Symfony
-    - php: '7.1'
-      env:
-        - SYMFONY_VERSION=4.0.*
     - php: '7.1'
       env:
         - SYMFONY_VERSION=4.1.*
@@ -77,12 +82,13 @@ matrix:
         - SYMFONY_VERSION=5.1.*
 
     # Test upcoming PHP versions with dev dependencies
-    - php: '7.4snapshot'
-      env:
-        - STABILITY=dev
-        - COMPOSER_FLAGS="--ignore-platform-reqs --prefer-stable"
+    #- php: '7.5snapshot'
+    #  env:
+    #    - STABILITY=dev
+    #    - COMPOSER_FLAGS="--ignore-platform-reqs --prefer-stable"
 
   allow_failures:
+    # 4.0 not supported because of https://github.com/advisories/GHSA-pgwj-prpq-jpc2
     - env:
         - SYMFONY_VERSION=4.0.*
     - env:

CHANGELOG.md

@@ -1,3 +1,7 @@
+# Version 2.1.1
+
+* Fixed some Symfony 5 compatibility issues
+
 # Version 2.1.0
 
 * Added CollectionWriter and DelegatorWriter

README.md

@@ -3,7 +3,7 @@
 DataflowBundle is a bundle for Symfony 3.4+ 
 providing an easy way to create import / export dataflow.
 
-[![Build Status](https://travis-ci.org/code-rhapsodie/dataflow-bundle.svg?branch=master)](https://travis-ci.org/code-rhapsodie/dataflow-bundle)
+[![Build Status](https://travis-ci.com/code-rhapsodie/dataflow-bundle.svg?branch=master)](https://travis-ci.com/code-rhapsodie/dataflow-bundle)
 
 [![Coverage Status](https://coveralls.io/repos/github/code-rhapsodie/dataflow-bundle/badge.svg)](https://coveralls.io/github/code-rhapsodie/dataflow-bundle)
 
@@ -35,6 +35,10 @@ As the following schema shows, you can define more than one dataflow:
 
 ## Installation
 
+Security notice: Symfony 4.x is not supported before 4.1.12, see https://github.com/advisories/GHSA-pgwj-prpq-jpc2
+
+And basically, every allowed-to-failed jobs in our travis configuration are not fully supported.
+
 ### Add the dependency
 
 To install this bundle, run this command :

composer.json

@@ -40,7 +40,7 @@
         "doctrine/dbal": "^2.0",
         "symfony/config": "^3.4||^4.0||^5.0",
         "symfony/console": "^3.4||^4.0||^5.0",
-        "symfony/dependency-injection": "^3.4||^4.0||^5.0",
+        "symfony/dependency-injection": "^3.4||>=4.1.12||^5.0",
         "symfony/event-dispatcher": "^3.4||^4.0||^5.0",
         "symfony/http-kernel": "^3.4||^4.0||^5.0",
         "symfony/lock": "^3.4||^4.0||^5.0",

src/Command/SchemaCommand.php

@@ -95,5 +95,7 @@ class SchemaCommand extends Command
         foreach ($sqls as $sql) {
             $io->text($sql.';');
         }
+
+        return 0;
     }
 }

src/DependencyInjection/Configuration.php

@@ -11,8 +11,13 @@ class Configuration implements ConfigurationInterface
 {
     public function getConfigTreeBuilder()
     {
-        $treeBuilder = new TreeBuilder();
-        $rootNode = $treeBuilder->root('code_rhapsodie_dataflow');
+        $treeBuilder = new TreeBuilder('code_rhapsodie_dataflow');
+        if (method_exists($treeBuilder, 'getRootNode')) {
+            $rootNode = $treeBuilder->getRootNode();
+        } else {
+            // BC for symfony/config < 4.2
+            $rootNode = $treeBuilder->root('code_rhapsodie_dataflow');
+        }
 
         $rootNode
             ->children()

src/Entity/Job.php

@@ -68,8 +68,6 @@ class Job
 
     /**
      * @var \DateTimeInterface|null
-     *
-     * @Asserts\DateTime()
      */
     private $requestedDate;