diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index df3b474..887284e 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,5 +1,4 @@ -Please do not submit any Pull Requests here. They will be closed. ---- +## Please do not submit any Pull Requests here. They will be closed. Please submit your PR here instead: https://github.com/symfony/ux diff --git a/.github/workflows/close-pull-request.yml b/.github/workflows/close-pull-request.yml index 57e4e3f..8150a6a 100644 --- a/.github/workflows/close-pull-request.yml +++ b/.github/workflows/close-pull-request.yml @@ -1,20 +1,20 @@ name: Close Pull Request on: - pull_request_target: - types: [opened] + pull_request_target: + types: [opened] jobs: - run: - runs-on: ubuntu-latest - steps: - - uses: superbrothers/close-pull-request@v3 - with: - comment: | - Thanks for your Pull Request! We love contributions. - - However, you should instead open your PR on the main repository: - https://github.com/symfony/ux - - This repository is what we call a "subtree split": a read-only subset of that main repository. - We're looking forward to your PR there! + run: + runs-on: ubuntu-latest + steps: + - uses: superbrothers/close-pull-request@v3 + with: + comment: | + Thanks for your Pull Request! We love contributions. + + However, you should instead open your PR on the main repository: + https://github.com/symfony/ux + + This repository is what we call a "subtree split": a read-only subset of that main repository. + We're looking forward to your PR there! diff --git a/.symfony.bundle.yaml b/.symfony.bundle.yaml index 6d9a74a..5662042 100644 --- a/.symfony.bundle.yaml +++ b/.symfony.bundle.yaml @@ -1,3 +1,3 @@ -branches: ["2.x"] -maintained_branches: ["2.x"] -doc_dir: "doc" +branches: ['2.x'] +maintained_branches: ['2.x'] +doc_dir: 'doc' diff --git a/CHANGELOG.md b/CHANGELOG.md index 901b587..83c3805 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,90 +2,90 @@ ## 2.30 -- Ensure compatibility with PHP 8.5 +- Ensure compatibility with PHP 8.5 ## 2.29.0 -- Add Symfony 8 support +- Add Symfony 8 support ## 2.23.0 -- Listen to Stimulus `disconnect` event to destroy the chart #1944 +- Listen to Stimulus `disconnect` event to destroy the chart #1944 ## 2.18.0 -- Replace `chartjs/auto` import with explicit `Chart.register()` call #1263 +- Replace `chartjs/auto` import with explicit `Chart.register()` call #1263 ## 2.17.0 -- Add `chartjs:view-value-change` event #1605 +- Add `chartjs:view-value-change` event #1605 ## 2.15.0 -- Remove restriction that prevented Chart.js 3.9 #1518 +- Remove restriction that prevented Chart.js 3.9 #1518 ## 2.14.0 -- Add support for Chart.js version 4 +- Add support for Chart.js version 4 ## 2.13.2 -- Change "module" key back to "main" in package.json +- Change "module" key back to "main" in package.json ## 2.13.1 -- Revert "Change JavaScript package to `type: module`" +- Revert "Change JavaScript package to `type: module`" ## 2.13.0 -- Add Symfony 7 support. -- Change JavaScript package to `type: module` +- Add Symfony 7 support. +- Change JavaScript package to `type: module` ## 2.9.0 -- Add support for symfony/asset-mapper +- Add support for symfony/asset-mapper -- Add dependency on symfony/stimulus-bundle +- Add dependency on symfony/stimulus-bundle -- Minimum required PHP version is now 8.1. +- Minimum required PHP version is now 8.1. -- Minimum required Symfony version is now 5.4. +- Minimum required Symfony version is now 5.4. ## 2.8.0 -- The chart will now automatically re-render if the `view` Stimulus value - (i.e. the `data-symfony--ux-chartjs--chart-view-value` attribute) changes. - This makes Chart.js work perfectly inside of a LiveComponent. +- The chart will now automatically re-render if the `view` Stimulus value + (i.e. the `data-symfony--ux-chartjs--chart-view-value` attribute) changes. + This makes Chart.js work perfectly inside of a LiveComponent. ## 2.7.0 -- The `chartjs:connect` JavaScript event now bubbles up. +- The `chartjs:connect` JavaScript event now bubbles up. -- Add `assets/src` to `.gitattributes` to exclude source TypeScript files from - installing. +- Add `assets/src` to `.gitattributes` to exclude source TypeScript files from + installing. -- TypeScript types are now included. +- TypeScript types are now included. ## 2.6.0 -- [BC BREAK] The `assets/` directory was moved from `Resources/assets/` to `assets/`. Make - sure the path in your `package.json` file is updated accordingly. +- [BC BREAK] The `assets/` directory was moved from `Resources/assets/` to `assets/`. Make + sure the path in your `package.json` file is updated accordingly. -- The directory structure of the bundle was updated to match modern best-practices. +- The directory structure of the bundle was updated to match modern best-practices. ## 2.0 -- Support for `stimulus` version 2 was removed and support for `@hotwired/stimulus` - version 3 was added. See the [@symfony/stimulus-bridge CHANGELOG](https://github.com/symfony/stimulus-bridge/blob/main/CHANGELOG.md#300) - for more details. -- Support added for Symfony 6 -- Upgrade Chart.js to version 3 +- Support for `stimulus` version 2 was removed and support for `@hotwired/stimulus` + version 3 was added. See the [@symfony/stimulus-bridge CHANGELOG](https://github.com/symfony/stimulus-bridge/blob/main/CHANGELOG.md#300) + for more details. +- Support added for Symfony 6 +- Upgrade Chart.js to version 3 ## 1.3 -- [DEPENDENCY CHANGE] `chart.js` is no longer included automatically (#93) - but `symfony/flex` will automatically add it to your `package.json` file - when upgrading. Additionally `symfony/flex` 1.13 or higher is now required - if installed. +- [DEPENDENCY CHANGE] `chart.js` is no longer included automatically (#93) + but `symfony/flex` will automatically add it to your `package.json` file + when upgrading. Additionally `symfony/flex` 1.13 or higher is now required + if installed. -- Chart.js: add horizontalBar type to chart model #87 - @duboiss +- Chart.js: add horizontalBar type to chart model #87 - @duboiss diff --git a/README.md b/README.md index 7b1309b..76a08f9 100644 --- a/README.md +++ b/README.md @@ -20,10 +20,10 @@ Help Symfony by [sponsoring][3] its development! ## Resources -- [Documentation](https://symfony.com/bundles/ux-chartjs/current/index.html) -- [Report issues](https://github.com/symfony/ux/issues) and - [send Pull Requests](https://github.com/symfony/ux/pulls) - in the [main Symfony UX repository](https://github.com/symfony/ux) +- [Documentation](https://symfony.com/bundles/ux-chartjs/current/index.html) +- [Report issues](https://github.com/symfony/ux/issues) and + [send Pull Requests](https://github.com/symfony/ux/pulls) + in the [main Symfony UX repository](https://github.com/symfony/ux) [1]: https://symfony.com/backers [2]: https://mercure.rocks diff --git a/assets/README.md b/assets/README.md index c6b0edd..b8c4b58 100644 --- a/assets/README.md +++ b/assets/README.md @@ -6,9 +6,10 @@ JavaScript assets of the [symfony/ux-chartjs](https://packagist.org/packages/sym This npm package is **reserved for advanced users** who want to decouple their JavaScript dependencies from their PHP dependencies (e.g., when building Docker images, running JavaScript-only pipelines, etc.). -We **strongly recommend not installing this package directly**, but instead install the PHP package [symfony/ux-chartjs](https://packagist.org/packages/symfony/ux-chartjs) in your Symfony application with [Flex](https://github.com/symfony/flex) enabled. +We **strongly recommend not installing this package directly**, but instead install the PHP package [symfony/ux-chartjs](https://packagist.org/packages/symfony/ux-chartjs) in your Symfony application with [Flex](https://github.com/symfony/flex) enabled. If you still want to install this package directly, please make sure its version exactly matches [symfony/ux-chartjs](https://packagist.org/packages/symfony/ux-chartjs) PHP package version: + ```shell composer require symfony/ux-chartjs:2.23.0 npm add @symfony/ux-chartjs@2.23.0 @@ -18,7 +19,7 @@ npm add @symfony/ux-chartjs@2.23.0 ## Resources -- [Documentation](https://symfony.com/bundles/ux-chartjs/current/index.html) -- [Report issues](https://github.com/symfony/ux/issues) and - [send Pull Requests](https://github.com/symfony/ux/pulls) - in the [main Symfony UX repository](https://github.com/symfony/ux) +- [Documentation](https://symfony.com/bundles/ux-chartjs/current/index.html) +- [Report issues](https://github.com/symfony/ux/issues) and + [send Pull Requests](https://github.com/symfony/ux/pulls) + in the [main Symfony UX repository](https://github.com/symfony/ux) diff --git a/assets/package.json b/assets/package.json index 175a406..dfbf3f8 100644 --- a/assets/package.json +++ b/assets/package.json @@ -20,9 +20,7 @@ "test": "pnpm run test:unit && pnpm run test:browser", "test:unit": "../../../bin/unit_test_package.sh .", "test:browser": "playwright test", - "test:browser:ui": "playwright test --ui", - "check": "biome check", - "ci": "biome ci" + "test:browser:ui": "playwright test --ui" }, "symfony": { "controllers": {