From cd23d4d80425e3f9be05b7c6d7c9456bf98ab180 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ole=20R=C3=B6=C3=9Fner?= Date: Sun, 28 Jul 2019 08:41:39 +0200 Subject: [PATCH 1/4] added receipe for basster/lazy-response-bundle 1.0 --- .../1.0/config/packages/basster_lazy_response.yaml | 13 +++++++++++++ basster/lazy-response-bundle/1.0/manifest.json | 5 +++++ 2 files changed, 18 insertions(+) create mode 100644 basster/lazy-response-bundle/1.0/config/packages/basster_lazy_response.yaml create mode 100644 basster/lazy-response-bundle/1.0/manifest.json diff --git a/basster/lazy-response-bundle/1.0/config/packages/basster_lazy_response.yaml b/basster/lazy-response-bundle/1.0/config/packages/basster_lazy_response.yaml new file mode 100644 index 00000000..8a8d230c --- /dev/null +++ b/basster/lazy-response-bundle/1.0/config/packages/basster_lazy_response.yaml @@ -0,0 +1,13 @@ +services: + _defaults: + public: false + autowire: true + autoconfigure: true + + # Enable DTO handler. + # Comment or remove a line, if you don't want to use the defaults or add + # your own handlers to the list. + # See any of the default handlers for reference. + Basster\LazyResponseBundle\Response\Handler\JsonSerializeResponseHandler: ~ + Basster\LazyResponseBundle\Response\Handler\RedirectResponseHandler: ~ + Basster\LazyResponseBundle\Response\Handler\TwigResponseHandler: ~ diff --git a/basster/lazy-response-bundle/1.0/manifest.json b/basster/lazy-response-bundle/1.0/manifest.json new file mode 100644 index 00000000..e164c6e6 --- /dev/null +++ b/basster/lazy-response-bundle/1.0/manifest.json @@ -0,0 +1,5 @@ +{ + "copy-from-recipe": { + "config/": "%CONFIG_DIR%/" + } +} From 0fb1b534c1d440491ba1e5bdc86585f886bdc3e3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ole=20R=C3=B6=C3=9Fner?= Date: Sun, 28 Jul 2019 12:47:09 +0200 Subject: [PATCH 2/4] slightly change a comment, to re-trigger a new review... --- .../1.0/config/packages/basster_lazy_response.yaml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/basster/lazy-response-bundle/1.0/config/packages/basster_lazy_response.yaml b/basster/lazy-response-bundle/1.0/config/packages/basster_lazy_response.yaml index 8a8d230c..bb2604e6 100644 --- a/basster/lazy-response-bundle/1.0/config/packages/basster_lazy_response.yaml +++ b/basster/lazy-response-bundle/1.0/config/packages/basster_lazy_response.yaml @@ -5,8 +5,7 @@ services: autoconfigure: true # Enable DTO handler. - # Comment or remove a line, if you don't want to use the defaults or add - # your own handlers to the list. + # Comment or remove a line, if you don't want to use the defaults or add your own handlers to the list. # See any of the default handlers for reference. Basster\LazyResponseBundle\Response\Handler\JsonSerializeResponseHandler: ~ Basster\LazyResponseBundle\Response\Handler\RedirectResponseHandler: ~ From f4e20693cf5d3439e3663ca0f4a0fb9715eebc22 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ole=20R=C3=B6=C3=9Fner?= Date: Thu, 15 Aug 2019 14:51:48 +0200 Subject: [PATCH 3/4] comment out handlers which require additional packages to run properly. Adopt description accordingly. --- .../1.0/config/packages/basster_lazy_response.yaml | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/basster/lazy-response-bundle/1.0/config/packages/basster_lazy_response.yaml b/basster/lazy-response-bundle/1.0/config/packages/basster_lazy_response.yaml index bb2604e6..07e26d7d 100644 --- a/basster/lazy-response-bundle/1.0/config/packages/basster_lazy_response.yaml +++ b/basster/lazy-response-bundle/1.0/config/packages/basster_lazy_response.yaml @@ -5,8 +5,14 @@ services: autoconfigure: true # Enable DTO handler. - # Comment or remove a line, if you don't want to use the defaults or add your own handlers to the list. + # Comment or remove, if you don't want to use the default. # See any of the default handlers for reference. - Basster\LazyResponseBundle\Response\Handler\JsonSerializeResponseHandler: ~ Basster\LazyResponseBundle\Response\Handler\RedirectResponseHandler: ~ - Basster\LazyResponseBundle\Response\Handler\TwigResponseHandler: ~ + + # Requires twig + # Basster\LazyResponseBundle\Response\Handler\TwigResponseHandler: ~ + + # Requires symfony/serializer + # Basster\LazyResponseBundle\Response\Handler\JsonSerializeResponseHandler: ~ + + # Feel free to add your own handlers: From 634f5a837f8a637d4dba063c13ca871d4e9e6ae3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ole=20R=C3=B6=C3=9Fner?= Date: Thu, 15 Aug 2019 14:52:42 +0200 Subject: [PATCH 4/4] symfony bot requested changes --- .../1.0/config/packages/basster_lazy_response.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/basster/lazy-response-bundle/1.0/config/packages/basster_lazy_response.yaml b/basster/lazy-response-bundle/1.0/config/packages/basster_lazy_response.yaml index 07e26d7d..054a0a98 100644 --- a/basster/lazy-response-bundle/1.0/config/packages/basster_lazy_response.yaml +++ b/basster/lazy-response-bundle/1.0/config/packages/basster_lazy_response.yaml @@ -7,12 +7,12 @@ services: # Enable DTO handler. # Comment or remove, if you don't want to use the default. # See any of the default handlers for reference. - Basster\LazyResponseBundle\Response\Handler\RedirectResponseHandler: ~ + Basster\LazyResponseBundle\Response\Handler\RedirectResponseHandler: null # Requires twig - # Basster\LazyResponseBundle\Response\Handler\TwigResponseHandler: ~ + # Basster\LazyResponseBundle\Response\Handler\TwigResponseHandler: null # Requires symfony/serializer - # Basster\LazyResponseBundle\Response\Handler\JsonSerializeResponseHandler: ~ + # Basster\LazyResponseBundle\Response\Handler\JsonSerializeResponseHandler: null # Feel free to add your own handlers: