119 Commits

Author SHA1 Message Date
Fabien Potencier
57ef7d396c minor #47390 [CS] Remove @inheritdoc PHPDoc (lyrixx)
This PR was merged into the 6.2 branch.

Discussion
----------

[CS] Remove `@inheritdoc` PHPDoc

| Q             | A
| ------------- | ---
| Branch?       | 6.2
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

---

It looks like this PHP Doc is useless. IDEs are able to inherit the doc (at least VS Code
and PHP Storm). And tools like PHP Stan are able to too https://phpstan.org/r/74a2c008-ff2b-42c0-8edf-8da87c1a7b5f

I could have open an RFC before doing the PR, but it was easy :) So let's discuss here

Commits
-------

015d5015e3 [CS] Remove `@inheritdoc` PHPDoc
2022-08-26 07:51:22 +02:00
Antoine Lamirault
4cf2940719 Remove usage of empty function when possible 2022-08-26 07:47:51 +02:00
Grégoire Pineau
fb7ade8fab [CS] Remove @inheritdoc PHPDoc 2022-08-25 17:27:04 +02:00
Thomas Calvet
2f62d5af2f Leverage non-capturing catches 2022-04-01 09:15:35 +02:00
Nicolas Grekas
927cdf2242 Merge branch '6.0' into 6.1
* 6.0:
  Revert "bug #45813 [HttpClient] Move Content-Type after Content-Length (nicolas-grekas)"
  [FrameworkBundle] Fix exit codes in debug:translation command
  [Cache] Declaratively declare/hide DoctrineProvider to avoid breaking static analysis
  [HttpClient] Let curl handle Content-Length headers
  Improve testsuite
  [HttpClient] Move Content-Type after Content-Length
  [HttpClient] minor cs fix
  [Config] Fix using null values with config builders
2022-03-22 17:20:03 +01:00
Nicolas Grekas
fdaa6d876f Merge branch '5.4' into 6.0
* 5.4:
  Revert "bug #45813 [HttpClient] Move Content-Type after Content-Length (nicolas-grekas)"
  [FrameworkBundle] Fix exit codes in debug:translation command
  [Cache] Declaratively declare/hide DoctrineProvider to avoid breaking static analysis
  [HttpClient] Let curl handle Content-Length headers
  Improve testsuite
  [HttpClient] Move Content-Type after Content-Length
  [HttpClient] minor cs fix
  [Config] Fix using null values with config builders
2022-03-22 17:12:04 +01:00
gndk
c843ab4739 [FrameworkBundle] Fix exit codes in debug:translation command
The `--only-missing` and `--only-unused` options should be independent of
each other.

When using the `--only-missing` option, only **missing** messages
should be relevant to the outcome of the execution. If there are no
missing messages, but some unused messages, the execution of the command
was still successful and no non-zero exit code should be returned.

The same applies when using the `--only-unused` option. In this case,
only **unused** messages should be relevant to the execution result,
even if there are some missing messages.
2022-03-22 16:51:09 +01:00
Fabien Potencier
dd3bf10773 Revert "bug #44494 Remove FQCN type hints on properties (fabpot)"
This reverts commit 0a13eba7037c6636be7a35c194d7d2e86d6ea6ba, reversing
changes made to e4cfa82c31ffda491b73e181c8d3d4e0a307eee8.
2021-12-09 13:46:12 +01:00
Fabien Potencier
a871a08baa Remove FQCN type hints on properties 2021-12-08 16:13:44 +01:00
Alexander M. Turek
bf9d0d4969 [FrameworkBundle] Add types to private properties 2021-11-02 11:55:16 +01:00
Fabien Potencier
84bc4b7d43 Merge branch '5.4' into 6.0
* 5.4:
  [FrameworkBundle] Add completion feature on translation:update command
  [Security] Backport 6.0 compat fixes
  Add completion feature on translation pull and push commands
  [Console] Add completion to debug:translation command
  [Console] Add autocompletion for security commands
  choose the proper array element to decode the message
  [RateLimiter] Add support for long intervals (months and years)
2021-10-29 17:34:49 +02:00
Alexandre Daubois
aa37f0ee70 [Console] Add completion to debug:translation command 2021-10-26 16:21:24 +02:00
Nicolas Grekas
54788c67a5 Use #[AsCommand] to describe commands 2021-09-30 17:28:07 +02:00
Roman Anasal
6a56e506c8 [FrameworkBundle] remove dead conditions in Translation Commands
Since $targetPath is directly set just 3 lines above
!isset($targetPath[1]) will *always* evaluate to true.

This check was originally to support legacy paths which was removed in
b6eb1f4979db346ffe9fe7f6a5f335323f0c7175
2021-08-05 14:03:35 +02:00
Fabien Potencier
3f8b570669 Merge branch '5.2' into 5.x
* 5.2:
  Fix #36973: Command description consistency
  Render email once
2021-03-06 09:05:19 +01:00
Fabien Potencier
a26f088761 Merge branch '4.4' into 5.2
* 4.4:
  Fix #36973: Command description consistency
  Render email once
2021-03-06 08:59:01 +01:00
Dane Powell
1d7c9a5590 Fix #36973: Command description consistency 2021-03-05 09:58:50 -08:00
Nate Wiebe
0087552850 [FrameworkBundle][Translation] Extract translation IDs from all of src 2021-03-05 13:17:50 +01:00
Nicolas Grekas
a2ab2c0854 [Console] enable describing commands in ways that make the list command lazy 2021-01-20 12:45:16 +01:00
Nicolas Grekas
0296d1c99a Merge branch '4.4' into 5.1
* 4.4:
  Update .php_cs.dist
  Apply "visibility_required" CS rule to constants
2020-12-08 18:02:38 +01:00
Nicolas Grekas
2b9098892e Apply "visibility_required" CS rule to constants
php-cs-fixer fix --rules='{"visibility_required": ["property", "method", "const"]}'
2020-12-08 17:59:59 +01:00
Nicolas Grekas
1e1d4eb97c Merge branch '3.4' into 4.4
* 3.4:
  Enable "native_constant_invocation" CS rule
  Make AbstractPhpFileCacheWarmer public
2020-09-02 18:08:58 +02:00
Nicolas Grekas
5da40103c3 Enable "native_constant_invocation" CS rule 2020-09-02 18:06:40 +02:00
Fabien Potencier
c7b17ce7e6 Fix quotes in exception messages 2020-03-16 12:24:17 +01:00
Arun Philip
3c9d3ebcb2 [FrameworkBundle][TranslationDebug] Return non-zero exit code on failure 2020-01-31 09:27:45 +01:00
Nicolas Grekas
e1d385e7fd Merge branch '4.4'
* 4.4: (24 commits)
  [Console] Command::execute() should always return int - deprecate returning null
  [FrameworkBundle] Fix wrong returned status code in ConfigDebugCommand
  [AnnotationCacheWarmer] add RedirectController to annotation cache
  [WebProfilerBundle] Try to display the most useful panel by default
  Add note about deprecating the XmlEncoder::TYPE_CASE_ATTRIBUTES constant in the upgrade guide
  fix merge
  [DI] add tests loading calls with returns-clone
  [DI] dont mandate a class on inline services with a factory
  Fixed Redis Sentinel usage when only one Sentinel specified
  [EventDispatcher] Added tests for aliased events.
  Sync Twig templateExists behaviors
  Fix the :only-of-type pseudo class selector
  Deprecate the XmlEncoder::TYPE_CASE_ATTRIBUTES constant
  [Mailer] Tweak some code
  [Serializer] Add CsvEncoder tests for PHP 7.4
  Copy phpunit.xsd to a predictable path
  [WebserverBundle] Remove duplicated deprecation message
  remove duplicated test
  [Security/Http] fix parsing X509 emailAddress
  [FrameworkBundle] conflict with VarDumper < 4.4
  ...
2019-10-02 17:00:37 +02:00
Jan Schädlich
38fc5d8a95 [Console] Command::execute() should always return int - deprecate returning null
- added deprecation message for non-int return value in Command::execute()
- fixed all core commands to return proper int values
- added proper return type-hint to Command::execute() method in all core Commands
2019-10-02 16:44:58 +02:00
Nicolas Grekas
4d82bb633f Merge branch '4.4'
* 4.4:
  [HttpKernel][FrameworkBundle] Add alternative convention for bundle directories
  [DI] deprecate support for non-object services
  [Translation] XliffLintCommand: allow .xliff file extension
  [Serializer] Encode empty objects as objects, not arrays
2019-08-13 15:43:55 +02:00
Yonel Ceruto
5d943040a7 [HttpKernel][FrameworkBundle] Add alternative convention for bundle directories 2019-08-13 15:29:02 +02:00
Nicolas Grekas
9d6dd76549 Merge branch '4.4'
* 4.4:
  Fix assertInternalType deprecation in phpunit 9
  Micro-typo fix
  add parameter type declarations to private methods
2019-08-01 11:33:55 +02:00
Christian Flothmann
3bc824354b add parameter type declarations to private methods 2019-07-31 20:51:46 +02:00
Nicolas Grekas
0064e75afa [FrameworkBundle] remove deprecated code paths 2019-06-06 19:13:23 +02:00
Yonel Ceruto
065671a758 Removed capability to load/debug/update legacy translation directories 2019-05-28 19:14:57 -04:00
Nicolas Grekas
107e1ab998 Merge branch '4.2'
* 4.2:
  fix translating file validation error message
  [Validator] Add missing Hungarian translations
  Improving deprecation message of the Twig templates directory src/Resources/views
  [3.4] [Validator] Add missing french validation translations.
  [Validator] Only traverse arrays that are cascaded into
  Handle case where no translations were found
  [Validator] Translate unique collection message to Hungarian
  fix tests
  Run test in separate process
  Use a class name that does not actually exist
  [Profiler] Fix dark theme elements color
  fix horizontal spacing of inlined Bootstrap forms
  [Translator] Warm up the translations cache in dev
  turn failed file uploads into form errors
2019-04-07 11:58:10 +02:00
Yonel Ceruto
a3f9bda13e Improving deprecation message of the Twig templates directory src/Resources/views 2019-04-07 10:37:45 +02:00
Yonel Ceruto
021f7d569f Added support for PHP files with translation in translation commands 2019-02-13 19:06:53 -05:00
Yonel Ceruto
d7f62db30a Add support for translator paths and twig paths in translation commands 2019-02-08 12:20:37 -05:00
Fabien Potencier
b36a29eff2 fixed CS 2019-01-16 21:35:37 +01:00
Fabien Potencier
ce7ef306e9 switched array() to [] 2019-01-16 10:39:14 +01:00
Yonel Ceruto
62ddd108a8 Also fix a bug for --all option 2018-11-07 13:41:09 -05:00
Yonel Ceruto
b8a2f6ea46 Cleaning translation commands 2018-11-07 11:54:53 -05:00
Robin Chalas
87cfc70258 [FrameworkBundle] Deprecate support for legacy translations and views directories 2018-10-27 16:37:38 +02:00
Nicolas Grekas
eaa85291cb [HttpKernel] fix deprecating KernelInterface::getRootDir() 2018-10-16 17:46:02 +02:00
Fabien Potencier
0bb202a5bf Merge branch '4.1'
* 4.1:
  [FWBundle] Uniformize errors when a component is missing
  Fixes 28816 Translation commands should not talk about the old app/ directory since 3.4
2018-10-16 03:11:07 +02:00
Fabien Potencier
0b313a3874 Merge branch '3.4' into 4.1
* 3.4:
  [FWBundle] Uniformize errors when a component is missing
  Fixes 28816 Translation commands should not talk about the old app/ directory since 3.4
2018-10-16 03:10:55 +02:00
Fabien Potencier
8fc56847d6 minor #28829 Translation commands should not tell about the old app/ directory (e-moe)
This PR was merged into the 3.4 branch.

Discussion
----------

Translation commands should not tell about the old app/ directory

Fixes #28816 Translation commands should not talk about the old "app/" directory since 3.4

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #28816
| License       | MIT
| Doc PR        | n/a

Commits
-------

5fcc0b4d8d Fixes 28816 Translation commands should not talk about the old app/ directory since 3.4
2018-10-16 02:41:49 +02:00
Fabien Potencier
af9f2c2d20 [HttpKernel] deprecated usage of getRootDir() and kernel.root_dir 2018-10-15 20:25:13 +02:00
Nikolay Labinskiy
6d573f8fc1 Fixes 28816 Translation commands should not talk about the old app/ directory since 3.4 2018-10-14 21:46:05 +03:00
Yonel Ceruto
b98cd6aaa2 Setting missing default paths under BC layer 2018-10-12 09:17:24 -04:00
Nicolas Grekas
61483dec58 Make trans + %count% parameter resolve plurals 2018-10-06 18:22:22 +02:00