61 Commits

Author SHA1 Message Date
Alexander M. Turek
0981f0b095 Prefix all sprintf() calls 2024-06-20 17:52:34 +02:00
Oskar Stark
8a2b584b1c [Filesystem][Finder][Form] Use CPP 2024-01-16 22:21:05 +01:00
Dariusz Ruminski
2edb77e943 CS: enable ordered_types.null_adjustment=always_last 2024-01-16 09:06:14 +01:00
François-Xavier de Guillebon
6c27f0a63a Replace get_class() calls by ::class 2022-09-01 04:03:18 +02:00
Fabien Potencier
1809b7a68a minor #47390 [CS] Remove @inheritdoc PHPDoc (lyrixx)
This PR was merged into the 6.2 branch.

Discussion
----------

[CS] Remove `@inheritdoc` PHPDoc

| Q             | A
| ------------- | ---
| Branch?       | 6.2
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

---

It looks like this PHP Doc is useless. IDEs are able to inherit the doc (at least VS Code
and PHP Storm). And tools like PHP Stan are able to too https://phpstan.org/r/74a2c008-ff2b-42c0-8edf-8da87c1a7b5f

I could have open an RFC before doing the PR, but it was easy :) So let's discuss here

Commits
-------

015d5015e3 [CS] Remove `@inheritdoc` PHPDoc
2022-08-26 07:51:22 +02:00
Antoine Lamirault
3be9604b0d Remove usage of empty function when possible 2022-08-26 07:47:51 +02:00
Grégoire Pineau
7dddf80606 [CS] Remove @inheritdoc PHPDoc 2022-08-25 17:27:04 +02:00
Thomas Calvet
b802731de9 Leverage non-capturing catches 2022-04-01 09:15:35 +02:00
Alexander M. Turek
b579d6abe4 Merge branch '5.4' into 6.0
* 5.4:
  fix SQLSRV throws for method_exists()
  [HttpKernel] Add basic support for language negotiation
  [Messenger] Add a middleware to log when transaction has been left open
  [HttpClient] Add method to set response factory in mock client
  Move array_merge calls out of loops to improve performance
  Remove references to DBALException
  [VarDumper] Fix handling of "new" in initializers on PHP 8.1
2021-10-05 23:23:30 +02:00
Simon Berger
299b56f718 Move array_merge calls out of loops to improve performance 2021-10-04 20:34:22 +02:00
Nicolas Grekas
00aeda6dd3 Add return types - batch 6/n 2021-08-16 17:45:02 +02:00
Alexander M. Turek
58332ad385 [Form] Add types to private properties
Signed-off-by: Alexander M. Turek <me@derrabus.de>
2021-07-27 21:25:40 +02:00
Alexander M. Turek
8f0fa124f2 Merge branch '4.4' into 5.2
* 4.4:
  [Form] Backport type fixes
  [Finder] Fix iterator return types
  [DependencyInjection] Support for intersection types
2021-07-15 14:19:23 +02:00
Alexander M. Turek
c8405e8bdc [Form] Backport type fixes
Signed-off-by: Alexander M. Turek <me@derrabus.de>
2021-07-15 14:00:28 +02:00
Valentin
c46149559a [Form] Add parameter type declarations 2019-08-13 09:00:05 +02:00
Fabien Potencier
60d5d61f9e Remove unneeded phpdocs 2019-08-08 11:37:48 +02:00
Alexander M. Turek
4079f37254 Turned return type annotations of private methods into php return types. 2019-08-07 16:19:54 +02:00
Jules Pietri
8dad268261 [Form] various minor fixes 2019-04-06 15:44:06 +02:00
Fabien Potencier
9e00d61b06 switched array() to [] 2019-01-16 10:39:14 +01:00
Nicolas Grekas
f7d085e31a Merge branch '2.8' into 3.4
* 2.8:
  Alpha-ordering for "use" statements
2018-07-26 11:06:28 +02:00
Nicolas Grekas
40861df328 Alpha-ordering for "use" statements 2018-07-26 11:03:18 +02:00
Nicolas Grekas
f5033153e3 Merge branch '2.8' into 3.4
* 2.8:
  Fix Clidumper tests
  Enable the fixer enforcing fully-qualified calls for compiler-optimized functions
  Apply fixers
  Disable the native_constant_invocation fixer until it can be scoped
  Update the list of excluded files for the CS fixer
2018-07-26 10:45:46 +02:00
Christophe Coevoet
15579a6424 Enable the fixer enforcing fully-qualified calls for compiler-optimized functions 2018-07-24 12:05:38 +02:00
Nicolas Grekas
53daf51333 Merge branch '2.8' into 3.4
* 2.8:
  Remove symfony/polyfill-ctype where not needed
  Use symfony/polyfill-ctype
  [Form] fixes instance variable phpdoc in FormRegistry class
2018-05-01 15:53:27 -07:00
Nicolas Grekas
7de5fd8dd1 Merge branch '2.7' into 2.8
* 2.7:
  Remove symfony/polyfill-ctype where not needed
  Use symfony/polyfill-ctype
  [Form] fixes instance variable phpdoc in FormRegistry class
2018-05-01 15:52:40 -07:00
Hugo Hamon
a6d3365f4c [Form] fixes instance variable phpdoc in FormRegistry class 2018-05-01 14:10:15 +02:00
Fabien Potencier
2f0f4e787e fixed some deprecation messages 2017-12-31 06:12:25 +01:00
Nicolas Grekas
a0c983220c Merge branch '3.3' into 3.4
* 3.3:
  [2.7] Fix issues found by PHPStan
  Add php_unit_dedicate_assert to PHPCS
  [WebProfilerBundle] Let fetch() cast URL to string
  improve FormType::getType exception message details
  [Intl] Update ICU data to 60.2
  [Console] fix a bug when you are passing a default value and passing -n would ouput the index
2017-12-20 12:08:06 +01:00
Nicolas Grekas
9508e43eb0 Merge branch '2.8' into 3.3
* 2.8:
  [2.7] Fix issues found by PHPStan
  Add php_unit_dedicate_assert to PHPCS
  improve FormType::getType exception message details
  [Intl] Update ICU data to 60.2
  [Console] fix a bug when you are passing a default value and passing -n would ouput the index
2017-12-20 12:04:02 +01:00
Nicolas Grekas
97a7dbf645 minor #25492 improve FormType::getType exception message details (Nicals)
This PR was submitted for the master branch but it was squashed and merged into the 2.8 branch instead (closes #25492).

Discussion
----------

improve FormType::getType exception message details

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

This pull request improves the exception thrown when a Type is requested from Symfony\Component\Form\FormRegistry.

The same exception message was thrown if either the Type class wasn't found or the Type class did not implement the Symfony\Component\Form\FormTypeInterface.

This pull request adds some explaination of the reason why a type could not be found and helps application developpers to find the source of the Symfony\Component\Form\Exception\InvalidArgumentException thrown when getting a Type.

Commits
-------

945f236 improve FormType::getType exception message details
2017-12-18 20:41:05 +01:00
Nicolas Appriou
24f9a0ce57 improve FormType::getType exception message details 2017-12-18 20:39:09 +01:00
Pierre du Plessis
d6f4c9bbf8 [Form] Fix error message in circular reference dependencies check 2017-10-10 13:20:13 +02:00
Pierre du Plessis
6e43dc016e [FORM] Prevent forms from extending itself as a parent 2017-10-10 12:07:08 +02:00
Nicolas Grekas
b1c9d58041 Merge branch '2.8' into 3.3
* 2.8: (22 commits)
  Tests and fix for issue in array model data in EntityType field with multiple=true
  [Form] Fixed PercentToLocalizedStringTransformer to accept both comma and dot as decimal separator, if possible
  removed useless PHPDoc
  [Form] Fix FormInterface::submit() annotation
  PdoSessionHandler: fix advisory lock for pgsql when session.sid_bits_per_character > 4
  HttpCache does not consider ESI resources in HEAD requests
  Fix translation for "This field was not expected"
  [Routing] Enhance Route(Collection) docblocks
  Added improvement for accuracy in MoneyToLocalizedStringTransformer.
  Removed unused private property
  Use correct verb form in the pull request template
  Use PHP_MAXPATHLEN in Filesystem.
  Added null as explicit return type (?TokenInterface)
  [FrameworkBundle] Fix Routing\DelegatingLoader
  Render all line breaks according to the exception message
  [Form] Fix phpdoc
  [DI] remove confusing code
  [Form] Fixed GroupSequence with "constraints" option
  [Validator] Clarify UUID validator behavior
  [Filesystem] Fixed makePathRelative
  ...
2017-10-02 08:42:24 +02:00
Nicolas Grekas
4d87609528 Merge branch '2.7' into 2.8
* 2.7: (22 commits)
  Tests and fix for issue in array model data in EntityType field with multiple=true
  [Form] Fixed PercentToLocalizedStringTransformer to accept both comma and dot as decimal separator, if possible
  removed useless PHPDoc
  [Form] Fix FormInterface::submit() annotation
  PdoSessionHandler: fix advisory lock for pgsql when session.sid_bits_per_character > 4
  HttpCache does not consider ESI resources in HEAD requests
  Fix translation for "This field was not expected"
  [Routing] Enhance Route(Collection) docblocks
  Added improvement for accuracy in MoneyToLocalizedStringTransformer.
  Removed unused private property
  Use correct verb form in the pull request template
  Use PHP_MAXPATHLEN in Filesystem.
  Added null as explicit return type (?TokenInterface)
  [FrameworkBundle] Fix Routing\DelegatingLoader
  Render all line breaks according to the exception message
  [Form] Fix phpdoc
  [DI] remove confusing code
  [Form] Fixed GroupSequence with "constraints" option
  [Validator] Clarify UUID validator behavior
  [Filesystem] Fixed makePathRelative
  ...
2017-10-01 23:00:16 +02:00
Oskar Stark
7b841ca7b1 removed useless PHPDoc 2017-09-30 07:00:23 -07:00
Fabien Potencier
c5f81d767b Merge branch '2.8' into 3.0
* 2.8:
  fixed CS
  fixed form tests
  [Console] Fix formatting of SymfonyStyle::comment()
  [Form] fix post max size translation type extension for >= 2.8
  removed dots at the end of @param and @return
  fixed typo
2016-06-29 07:40:00 +02:00
Fabien Potencier
fd24c42112 Merge branch '2.7' into 2.8
* 2.7:
  removed dots at the end of @param and @return
  fixed typo
2016-06-29 07:29:29 +02:00
Fabien Potencier
19154a6317 removed dots at the end of @param and @return 2016-06-28 08:24:06 +02:00
Thomas Rabaix
92f0b6f63f fix type assignement 2015-11-25 16:48:40 +01:00
Nicolas Grekas
d0a833a99a [Form] Enhance some FormRegistry deprecation messages 2015-11-17 11:33:11 +01:00
Tobias Schultze
3b00ccf1e4 Merge branch '2.8'
Conflicts:
	CHANGELOG-2.3.md
	CHANGELOG-2.7.md
	composer.json
	src/Symfony/Bridge/Twig/composer.json
	src/Symfony/Bundle/FrameworkBundle/composer.json
	src/Symfony/Bundle/SecurityBundle/composer.json
	src/Symfony/Component/Console/Tests/Helper/LegacyProgressHelperTest.php
	src/Symfony/Component/Console/Tests/Helper/LegacyTableHelperTest.php
	src/Symfony/Component/Console/composer.json
	src/Symfony/Component/DomCrawler/composer.json
	src/Symfony/Component/Form/Tests/FormRegistryTest.php
	src/Symfony/Component/Form/composer.json
	src/Symfony/Component/HttpFoundation/composer.json
	src/Symfony/Component/HttpKernel/Tests/Profiler/MongoDbProfilerStorageTest.php
	src/Symfony/Component/Intl/composer.json
	src/Symfony/Component/Ldap/composer.json
	src/Symfony/Component/Security/Core/composer.json
	src/Symfony/Component/Security/Csrf/composer.json
	src/Symfony/Component/Security/Http/composer.json
	src/Symfony/Component/Security/composer.json
	src/Symfony/Component/Serializer/Encoder/JsonEncoder.php
	src/Symfony/Component/Serializer/composer.json
	src/Symfony/Component/Templating/PhpEngine.php
	src/Symfony/Component/Translation/composer.json
	src/Symfony/Component/VarDumper/Tests/HtmlDumperTest.php
	src/Symfony/Component/VarDumper/composer.json
2015-10-29 13:12:54 +01:00
Fabien Potencier
443dd30f53 Merge branch '2.7' into 2.8
* 2.7:
  fixed YAML files missing quotes when a string starts with @
  [VarDumper] Fix anonymous class dumping
  [Routing] mark internal classes
  [Translation][Csv file] remove unnecessary statements, for better readability.
  [Form] remove validation of FormRegistry::getType as FormRegistry::hasType does not validate either
2015-10-27 08:40:42 -07:00
Tobias Schultze
3e82fcc4d2 [Form] remove validation of FormRegistry::getType as FormRegistry::hasType does not validate either
also developers do not work with the registry directly anyway but through the factory. and the factory already validates the value.
2015-10-22 02:46:43 +02:00
Fabien Potencier
08f76324a8 [Form] removed deprecated FormType::getName() 2015-10-01 16:20:48 +02:00
Fabien Potencier
5ec8e1defc [Form] made deprecation notice more precise 2015-08-24 09:31:47 +02:00
Bernhard Schussek
3b14634489 [Form] Deprecated FormTypeInterface::getName() and passing of type instances 2015-07-02 10:02:46 +02:00
Graham Campbell
1082181742 [2.3] CS And DocBlock Fixes 2014-12-22 16:58:09 +01:00
Joseph Bielawski
36457711c8 [2.3][Form] Cleanup & fix phpdocs 2014-07-09 12:39:32 +02:00
Alexander Kotynia
d448780fc0 [Form] Make exception handling consistent with other components 2013-04-20 00:34:27 +03:00