From 8f6d3ecb5ae72d1f21af58fc7ec50a4d9e4273e4 Mon Sep 17 00:00:00 2001
From: Alexandre Daubois <alex.daubois@gmail.com>
Date: Mon, 14 Oct 2024 20:03:05 +0200
Subject: [PATCH] Reduce common control flows

---
 Completion/CompletionInput.php     | 4 ++--
 Tests/Logger/ConsoleLoggerTest.php | 6 +-----
 2 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/Completion/CompletionInput.php b/Completion/CompletionInput.php
index 50febf2d..9f9619e1 100644
--- a/Completion/CompletionInput.php
+++ b/Completion/CompletionInput.php
@@ -123,13 +123,13 @@ final class CompletionInput extends ArgvInput
         if ($this->currentIndex >= \count($this->tokens)) {
             if (!isset($this->arguments[$argumentName]) || $this->definition->getArgument($argumentName)->isArray()) {
                 $this->completionName = $argumentName;
-                $this->completionValue = '';
             } else {
                 // we've reached the end
                 $this->completionType = self::TYPE_NONE;
                 $this->completionName = null;
-                $this->completionValue = '';
             }
+
+            $this->completionValue = '';
         }
     }
 
diff --git a/Tests/Logger/ConsoleLoggerTest.php b/Tests/Logger/ConsoleLoggerTest.php
index 43d77963..0464c8c5 100644
--- a/Tests/Logger/ConsoleLoggerTest.php
+++ b/Tests/Logger/ConsoleLoggerTest.php
@@ -151,11 +151,7 @@ class ConsoleLoggerTest extends TestCase
 
     public function testObjectCastToString()
     {
-        if (method_exists($this, 'createPartialMock')) {
-            $dummy = $this->createPartialMock(DummyTest::class, ['__toString']);
-        } else {
-            $dummy = $this->createPartialMock(DummyTest::class, ['__toString']);
-        }
+        $dummy = $this->createPartialMock(DummyTest::class, ['__toString']);
         $dummy->method('__toString')->willReturn('DUMMY');
 
         $this->getLogger()->warning($dummy);