php/web-rmtools
1
0
Fork 0
mirror of https://github.com/php/web-rmtools.git synced 2026-03-24 17:22:12 +01:00
Code Issues 12 Packages Projects Releases Wiki Activity

[PR #6] [CLOSED] Fix #77728: pgort140.DLL missing #4

New Issue
Closed
opened 2026-01-24 11:41:37 +01:00 by admin · 0 comments
admin commented 2026-01-24 11:41:37 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/php/web-rmtools/pull/6
Author: @cmb69
Created: 3/25/2019
Status: ❌ Closed

Base: master ← Head: bug-77728

📝 Commits (3)

📊 Changes

1 file changed (+23 additions, -17 deletions)

View changed files

📝 script/snap.php (+23 -17)

📄 Description

If a PGO build is requested, but a build error occurs after the PGI
build has succeeded and before the PGO build has even been attempted
(for instance, if the PGO training fails), we may get a bogus archive
containing the PGI build, without any hint. We apply a quick fix which
requires to run the PGO build if requested, and reports a respective
error otherwise.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/php/web-rmtools/pull/6 **Author:** [@cmb69](https://github.com/cmb69) **Created:** 3/25/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `bug-77728` --- ### 📝 Commits (3) - [`97dc0af`](https://github.com/php/web-rmtools/commit/97dc0af4508f937208c9dbe4b557c04f9ee08dee) Fix #77728: pgort140.DLL missing - [`90416bf`](https://github.com/php/web-rmtools/commit/90416bf4c5129a626fee65cb8a87ae96a1fd56b5) Don't go on after failure - [`ced1dad`](https://github.com/php/web-rmtools/commit/ced1dad0fe911f696f843bce550ed3b0fedd9340) Allow PGO training to fail ### 📊 Changes **1 file changed** (+23 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `script/snap.php` (+23 -17) </details> ### 📄 Description If a PGO build is requested, but a build error occurs after the PGI build has succeeded and before the PGO build has even been attempted (for instance, if the PGO training fails), we may get a bogus archive containing the PGI build, without any hint. We apply a quick fix which requires to run the PGO build if requested, and reports a respective error otherwise. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
admin added the pull-request label 2026-01-24 11:41:37 +01:00
admin closed this issue 2026-01-24 11:41:37 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: php/web-rmtools#4
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?