[PR #13] Support extensions with config.w32 in subfolder #26

New Issue

admin · 2026-01-24T11:41:40+01:00

admin commented

2026-01-24 11:41:40 +01:00

Original Pull Request: https://github.com/php/web-rmtools/pull/13

State: closed
Merged: No

Some extensions have the actual extension code in a subfolder of the
toplevel package folder, and as such can't currently be built. For
instance, xhprof has xhprof-x.y.z/extension/config.w32, but we only
check for xhprof-x.y.z/config.w32 and config.w32.

Changing PeclExt::tmp_extract_path to point to the subfolder which
contains ' config.w32` wouldn't work, though, because then the folders
in package.xml won't match anymore. Therefore, we attempt to copy the
whole subfolder one level up, and resume the build process.

**Original Pull Request:** https://github.com/php/web-rmtools/pull/13 **State:** closed **Merged:** No --- Some extensions have the actual extension code in a subfolder of the toplevel package folder, and as such can't currently be built. For instance, xhprof has `xhprof-x.y.z/extension/config.w32`, but we only check for `xhprof-x.y.z/config.w32` and `config.w32`. Changing `PeclExt::tmp_extract_path` to point to the subfolder which contains ' config.w32` wouldn't work, though, because then the folders in package.xml won't match anymore. Therefore, we attempt to copy the whole subfolder one level up, and resume the build process.

admin added the pull-request label 2026-01-24 11:41:40 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: php/web-rmtools#26