php/web-rmtools
1
0
Fork 0
mirror of https://github.com/php/web-rmtools.git synced 2026-03-24 09:12:18 +01:00
Code Issues 12 Packages Projects Releases Wiki Activity

[PR #15] Increase length of short ref #23

New Issue
Closed
opened 2026-01-24 11:41:40 +01:00 by admin · 0 comments
admin commented 2026-01-24 11:41:40 +01:00
Owner
Copy Link

Original Pull Request: https://github.com/php/web-rmtools/pull/15

State: closed
Merged: No

Latest commit on master branch of php-src is inaccessible using short commit hash of 7 characters, so the zip file fails to download.
For hash 6768f4705cf0603d4770e3825795ec6b30bbb8c1, these URLs would 404.

https://github.com/php/php-src/commit/6768f47
https://codeload.github.com/php/php-src/zip/6768f47

This results in this error, as the zip fails to download

Fatal error: Uncaught Exception: Failed to rename 'C:/php-snap-build/obj-x64\ts-windows-vs16-x64-6768f47-tmp-unzip/php-src-6768f47' to 'C:/php-snap-build/obj-x64/master-src-ts-windows-vs16-x64-r6768f47' in C:\php-snap-build\rmtools\include\Branch.php:276

Increasing the length to 10 characters would be a good fix as git log --oneline currently on php-src uses 10 characters for shortening commit hashes.

$ git log --oneline
6768f4705c (HEAD -> master, up/master, 6768f47) Merge branch 'PHP-8.0'
49ca191667 (up/PHP-8.0, PHP-8.0) Merge branch 'PHP-7.4' into PHP-8.0
77b6e95d92 (up/PHP-7.4) Split tests for compatibility with ICU 68.1
...
...

Relevant discussion: https://stackoverflow.com/questions/18134627

**Original Pull Request:** https://github.com/php/web-rmtools/pull/15 **State:** closed **Merged:** No --- Latest commit on `master` branch of `php-src` is inaccessible using short commit hash of 7 characters, so the zip file fails to download. For hash `6768f4705cf0603d4770e3825795ec6b30bbb8c1`, these URLs would `404`. ``` https://github.com/php/php-src/commit/6768f47 https://codeload.github.com/php/php-src/zip/6768f47 ``` This results in this [error](https://github.com/shivammathur/php-builder-windows/runs/1366632460?check_suite_focus=true#step:9:20), as the zip fails to download ``` Fatal error: Uncaught Exception: Failed to rename 'C:/php-snap-build/obj-x64\ts-windows-vs16-x64-6768f47-tmp-unzip/php-src-6768f47' to 'C:/php-snap-build/obj-x64/master-src-ts-windows-vs16-x64-r6768f47' in C:\php-snap-build\rmtools\include\Branch.php:276 ``` Increasing the length to 10 characters would be a good fix as `git log --oneline` currently on `php-src` uses 10 characters for shortening commit hashes. ``` $ git log --oneline 6768f4705c (HEAD -> master, up/master, 6768f47) Merge branch 'PHP-8.0' 49ca191667 (up/PHP-8.0, PHP-8.0) Merge branch 'PHP-7.4' into PHP-8.0 77b6e95d92 (up/PHP-7.4) Split tests for compatibility with ICU 68.1 ... ... ``` **Relevant discussion:** https://stackoverflow.com/questions/18134627
admin added the pull-request label 2026-01-24 11:41:40 +01:00
admin closed this issue 2026-01-24 11:41:40 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: php/web-rmtools#23
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?