[PR #13] [CLOSED] Support extensions with config.w32 in subfolder #21

New Issue

admin · 2026-01-24T11:41:39+01:00

admin commented

2026-01-24 11:41:39 +01:00

📋 Pull Request Information

Original PR: https://github.com/php/web-rmtools/pull/13
Author: @cmb69
Created: 12/18/2019
Status: ❌ Closed

Base: master ← Head: cmb/subfolder-support

📝 Commits (1)

ab5ba53 Support extensions with config.w32 in subfolder

📊 Changes

1 file changed (+33 additions, -2 deletions)

View changed files

📝 include/PeclExt.php (+33 -2)

📄 Description

Some extensions have the actual extension code in a subfolder of the
toplevel package folder, and as such can't currently be built. For
instance, xhprof has xhprof-x.y.z/extension/config.w32, but we only
check for xhprof-x.y.z/config.w32 and config.w32.

Changing PeclExt::tmp_extract_path to point to the subfolder which
contains ' config.w32` wouldn't work, though, because then the folders
in package.xml won't match anymore. Therefore, we attempt to copy the
whole subfolder one level up, and resume the build process.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/php/web-rmtools/pull/13 **Author:** [@cmb69](https://github.com/cmb69) **Created:** 12/18/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `cmb/subfolder-support` --- ### 📝 Commits (1) - [`ab5ba53`](https://github.com/php/web-rmtools/commit/ab5ba530e3880c1542c829e0a2e5f01514a64f76) Support extensions with config.w32 in subfolder ### 📊 Changes **1 file changed** (+33 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `include/PeclExt.php` (+33 -2) </details> ### 📄 Description Some extensions have the actual extension code in a subfolder of the toplevel package folder, and as such can't currently be built. For instance, xhprof has `xhprof-x.y.z/extension/config.w32`, but we only check for `xhprof-x.y.z/config.w32` and `config.w32`. Changing `PeclExt::tmp_extract_path` to point to the subfolder which contains ' config.w32` wouldn't work, though, because then the folders in package.xml won't match anymore. Therefore, we attempt to copy the whole subfolder one level up, and resume the build process. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

admin added the pull-request label 2026-01-24 11:41:39 +01:00

admin referenced this issue

2026-01-24 11:41:41 +01:00

[PR #21] [CLOSED] Add config for PHP 8.3 #29

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: php/web-rmtools#21